Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mpris plugin #346

Closed
wants to merge 1 commit into from
Closed

Remove mpris plugin #346

wants to merge 1 commit into from

Conversation

TingPing
Copy link
Member

@TingPing TingPing commented Dec 4, 2023

It is a third party plugin that is causing crashes.

It is unfair to mpv to include it by default. This should go into an extension.

Closes #81

It is a third party plugin that is causing crashes.

It is unfair to mpv to include it by default. This should go into an extension.

Closes #81
@flathubbot
Copy link
Contributor

Started test build 85508

@flathubbot
Copy link
Contributor

Build 85508 failed

@fastrizwaan
Copy link
Collaborator

@TingPing there are no crashes because of mpris. Pablo is using mpv in cli or in a script, and using ctrl+c to exit it, session-bus is required for it to not throw error for SIGINT (ctrl+c). flatpak sandbox is not handling ctrl+c properly because of lack of --socket=session-bus, that's not a bug .

@fastrizwaan
Copy link
Collaborator

and an extension would be great, if you can make it, I tried but failed. finally someone thought of it after 10 monhts. https://github.com/fastrizwaan/mpv_extensions

@TingPing
Copy link
Member Author

TingPing commented Dec 6, 2023

flatpak sandbox is not handling ctrl+c properly because of lack of --socket=session-bus, that's not a bug .

No application needs session-bus permissions. There is just some bug in the plugin. It should never crash.

@ssokolow
Copy link

ssokolow commented May 1, 2024

Remove mpris plugin

Please don't. It's not at all easy to put it back if the user wants it because of the difficulties in building a compatible .so file when the Freedesktop runtime has different library versions than the host distro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundled MPRIS plugin can error on SIGINT
4 participants