This repository has been archived by the owner on May 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm annoyed that this package still pulls old stuff, so that's why I'm making this change
Imagine using a 38 year old insecure display server mess in 2023 X11 fallback is provided for those two dwm chads (at least when all major distros ship Wayland DEs/WMs by default)
I don't want Discord having unlimited access to my nudes Normal file upload should still work with the file portal Those two dwm chads without portals can manually specify the directories they want to access
This makes global keyboard shortcuts work in KDE kglobalaccel package is (probably) required though
This should allow notifications to work without portal support This change is important for wlroots users
Started test build 21341 |
Build 21341 successful
|
Started test build 21982 |
maltejur
suggested changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
Build 21982 successful
|
Source: https://github.com/flathub/com.discordapp.Discord/blob/8734a0f84ba75749adce79d854b5db3c5d175f02/com.discordapp.Discord.json#L20-L22 I had to do this to make this PR approved by @maltejur 🐸
Started test build 22819 |
Build 22819 successful
|
maltejur
approved these changes
Feb 12, 2023
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed some annoying things with this Flatpak package, so
that's why I'm making this PR
I've tested the majority of these changes in my local version
The reasoning of these changes can be found in the commit messages