Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "remember password" option #66

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

austin-ek
Copy link
Contributor

@austin-ek austin-ek commented Apr 2, 2023

Currently, "remember password" fails because the flatpak does not have permission fororg.freedesktop.secrets on the session bus. This can be easily fixed using flatpak override or Flatseal. This just adds the permission by default.

Tested on Fedora Silverblue 38 Beta

@flathubbot
Copy link
Contributor

Started test build 32251

@flathubbot
Copy link
Contributor

Build 32251 failed

@Erick555
Copy link
Contributor

Erick555 commented Apr 2, 2023

You need to find out specific address instead of whole bus.

Try flatpak run --log-session-bus com.yubico.yubioath to find out.

@flathubbot
Copy link
Contributor

Started test build 32269

@flathubbot
Copy link
Contributor

Build 32269 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14915/com.yubico.yubioath.flatpakref

@austin-ek
Copy link
Contributor Author

You need to find out specific address instead of whole bus.

Try flatpak run --log-session-bus com.yubico.yubioath to find out.

Thanks. I've updated it.

@Lunarequest
Copy link
Collaborator

LGTM

@Lunarequest Lunarequest merged commit 1d86282 into flathub:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants