Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension point for MUI #87

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add extension point for MUI #87

wants to merge 3 commits into from

Conversation

gasinvein
Copy link
Member

Closes #86

@flathubbot
Copy link
Contributor

Started test build 32520

@flathubbot
Copy link
Contributor

Build 32520 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/31330/com.wps.Office.flatpakref

@gasinvein
Copy link
Member Author

@ccat3z This would allow you to create an extension like com.wps.Office.MUI.zh_CN, which, once installed, will be mounted and symlinked at /app/extra/wps-office/office6/mui/zh_CN. Is this what you needed?

@ccat3z
Copy link

ccat3z commented Nov 15, 2020

It works. Thank you!

ln -sr "/app/share/wps-office/office6/$target/$lang" "wps-office/office6/$target/$lang"

Maybe it's better to link to /app/share/wps-office/office6/$target/$lang/extra or somewhere? It seems that only the extra folder is writable at the apply_extra stage. I am not familiar with flatpak-builder. I'm sorry if I misunderstood.

@gasinvein
Copy link
Member Author

If you need extra-data in extension, you can put payload in extra/ directory, and create a symlink for each file in it from its parent directory, e.g. zh_CN.png -> extra/zh_CN.png

@ccat3z
Copy link

ccat3z commented Nov 15, 2020

All right.

@gasinvein
Copy link
Member Author

On the other hand, symlinking each file might be tricky. Probably we should use a subdir indeed, so only it would need to be symlinked to extra.

@flathubbot
Copy link
Contributor

Started test build 32534

@flathubbot
Copy link
Contributor

Build 32534 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/31344/com.wps.Office.flatpakref

@gasinvein
Copy link
Member Author

@ccat3z Ok, added data subdir. It can be a symlink to extra in case of non-redistributable langpack, or to . otherwise.

@catsout
Copy link

catsout commented Jan 8, 2022

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zh_CN support
4 participants