This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Add libnotify support, update (some) dependencies #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started test build 97791 |
|
Build 97791 successful |
You don't need to build PyQt5. Just use com.riverbankcomputing.PyQt.BaseApp. |
|
It looks like it built fine. Thanks a lot! :-) It was in my TODO, but I sadly do not have much free time lately. I will keep the PyQt5 module for now, we can switch to the PyQt.BaseApp later if desired. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds libnotify support, which should close #42. I've built and tested it locally and it seems to work as expected. It also updates some dependencies. It seems as requests most be updated before charset-normalizer can be bumped to version 2.1.0, please see psf/requests#6169. I've not been able to build the newest version of PyQt5 locally. It seems as the Flathub builder has the same problem.