Enable wayland by default, fallback to X11 #99

ghisvail · 2022-05-05T18:05:26Z

No description provided.

flathubbot · 2022-05-05T18:05:39Z

flathubbot · 2022-05-05T18:08:55Z

Build 89959 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87752/com.bitwarden.desktop.flatpakref

flathubbot · 2022-05-09T10:47:47Z

Started test build 90422

flathubbot · 2022-05-09T10:51:24Z

Build 90422 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88207/com.bitwarden.desktop.flatpakref

flathubbot · 2022-06-03T11:46:19Z

Started test build 94526

flathubbot · 2022-06-03T11:49:19Z

Build 94526 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/92258/com.bitwarden.desktop.flatpakref

TheEvilSkeleton · 2022-07-07T02:29:29Z

com.bitwarden.desktop.yaml

      - type: script
        dest-filename: bitwarden.sh
        commands:
-          - export TMPDIR="$XDG_RUNTIME_DIR/app/$FLATPAK_ID"
-          - exec zypak-wrapper /app/Bitwarden/bitwarden "$@"
+          - export TMPDIR="${XDG_RUNTIME_DIR}/app/${FLATPAK_ID}"
+          - if [ "${XDG_SESSION_TYPE}" == "wayland" ]; then
+          - zypak-wrapper /app/Bitwarden/bitwarden --enable-features=UseOzonePlatform --ozone-platform=wayland "$@"
+          - else
+          - zypak-wrapper /app/Bitwarden/bitwarden "$@"
+          - fi


Just my two cent: the structure of it is displeasing. I suggest writing a separate bash script.

flathubbot · 2022-08-15T11:38:45Z

Started test build 105042

flathubbot · 2022-08-15T11:41:07Z

Build 105042 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102727/com.bitwarden.desktop.flatpakref

proletarius101 · 2022-12-29T15:13:38Z

They have updated Electron to 21: https://github.com/bitwarden/clients/blob/2ac8e27b319a3873ace0ea418f1c51d5b4c08b21/package.json#L82. After the next release, the flag should be changed to

--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations

ghisvail · 2022-12-29T16:39:53Z

@proletarius101 thanks for the heads up 👍

flathubbot · 2022-12-29T16:40:18Z

Started test build 14162

flathubbot · 2022-12-29T16:42:11Z

Started test build 14163

flathubbot · 2022-12-29T16:42:23Z

Build 14162 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/126589/com.bitwarden.desktop.flatpakref

flathubbot · 2022-12-29T16:43:54Z

Build 14163 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/126590/com.bitwarden.desktop.flatpakref

flathubbot · 2023-01-14T22:53:15Z

Started test build 17371

flathubbot · 2023-01-14T22:53:22Z

Build 17371 failed

flathubbot · 2023-01-14T23:16:58Z

Started test build 17376

flathubbot · 2023-01-14T23:19:06Z

Build 17376 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/1/com.bitwarden.desktop.flatpakref

flathubbot · 2023-01-14T23:21:18Z

Started test build 17381

flathubbot · 2023-01-14T23:23:44Z

Build 17381 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/6/com.bitwarden.desktop.flatpakref

flathubbot · 2023-01-18T09:09:27Z

Started test build 17966

flathubbot · 2023-01-18T09:11:36Z

Build 17966 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/596/com.bitwarden.desktop.flatpakref

taaem · 2023-09-05T12:41:29Z

The second one should not be fixed like that but instead like this (see https://github.com/flathub/com.visualstudio.code/blob/master/com.visualstudio.code.yaml#L26C1-L26C46):

  - --system-talk-name=org.freedesktop.login1

taaem · 2023-09-05T12:45:08Z

Sorry for the update again, but according to https://github.com/electron/electron/blob/main/shell/browser/lib/power_observer_linux.cc#L18 the correct fix would be:

  - --system-talk-name=org.freedesktop.login1
  - --system-talk-name=org.freedesktop.login1.Manager

ghisvail · 2023-09-05T12:47:16Z

Sorry for the update again, but according to https://github.com/electron/electron/blob/main/shell/browser/lib/power_observer_linux.cc#L18 the correct fix would be:
  - --system-talk-name=org.freedesktop.login1
  - --system-talk-name=org.freedesktop.login1.Manager

Thank you for investigating this. Could you submit this fix in a separate PR?

taaem · 2023-09-05T12:48:14Z

@ghisvail I will in a second :)

taaem · 2023-09-05T13:02:25Z

@ghisvail should I also add the other fix in the new pr?

ghisvail · 2023-09-05T13:41:19Z

yes please

flathubbot · 2023-09-06T19:40:13Z

Started test build 63711

flathubbot · 2023-09-06T19:42:39Z

Build 63711 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/46349/com.bitwarden.desktop.flatpakref

flathubbot · 2023-09-09T06:18:14Z

Started test build 64396

ghisvail · 2023-09-09T06:18:35Z

@taaem could you test it again, now that your changes are in?

flathubbot · 2023-09-09T06:20:56Z

Build 64396 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/47030/com.bitwarden.desktop.flatpakref

taaem · 2023-09-11T21:43:54Z

@ghisvail everything works for me now on wayland :)

cassidyjames · 2023-11-08T23:32:17Z

Testing locally on Endless OS on Wayland, and it works. It seems to fix #165 for me as well.

flathubbot · 2023-11-12T08:59:06Z

Started test build 81040

flathubbot · 2023-11-12T09:06:22Z

Build 81040 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/63677/com.bitwarden.desktop.flatpakref

ghisvail · 2023-11-12T09:11:50Z

Looks like it's working on my X11 session too.

This reverts commit 1eef6b2.

There is an issue upstream with copy and paste on pure Wayland. Users have reported that keeping the X11 socket alive solves it. To be reverted when upstream fixes the issue for good. * Revert "Enable wayland by default, fallback to X11 (#99)" This reverts commit 1eef6b2. * Update com.bitwarden.desktop.yaml Co-authored-by: Tilo Spannagel <[email protected]> --------- Co-authored-by: Ghislain Vaillant <[email protected]> Co-authored-by: Tilo Spannagel <[email protected]>

ghisvail force-pushed the enable-wayland branch from c2fcee3 to 1658bb3 Compare May 9, 2022 10:47

ghisvail force-pushed the enable-wayland branch from 1658bb3 to cb7431e Compare June 3, 2022 11:46

TheEvilSkeleton suggested changes Jul 7, 2022

View reviewed changes

ghisvail force-pushed the enable-wayland branch from cb7431e to de8cece Compare August 15, 2022 11:38

DoodlesEpic approved these changes Sep 1, 2022

View reviewed changes

ghisvail force-pushed the enable-wayland branch from de8cece to dea0605 Compare December 29, 2022 16:40

ghisvail force-pushed the enable-wayland branch from 83471af to 7ff155f Compare January 14, 2023 22:53

proletarius101 mentioned this pull request Jan 24, 2023

Build from source & enable aarch64 build #55

Open

taaem mentioned this pull request Sep 5, 2023

allow bitwarden to talk to org.freedesktop.login1 #153

Merged

taaem mentioned this pull request Sep 5, 2023

add env XCURSOR to get the correct cursor on wayland #154

Merged

ghisvail force-pushed the enable-wayland branch from e013e1f to cdb70f9 Compare September 6, 2023 19:39

ghisvail force-pushed the enable-wayland branch from cdb70f9 to fb3b3b6 Compare September 9, 2023 06:18

ghisvail and others added 3 commits November 12, 2023 09:58

Enable wayland by default, fallback to X11

a127f70

Update Wayland flags

7662d47

Update wrapper script

b46b07d

ghisvail force-pushed the enable-wayland branch from fb3b3b6 to b46b07d Compare November 12, 2023 08:58

ghisvail merged commit 1eef6b2 into master Nov 12, 2023
1 check passed

ghisvail deleted the enable-wayland branch November 12, 2023 10:04

evan-a-a added a commit to evan-a-a/com.bitwarden.desktop that referenced this pull request Nov 14, 2023

Revert "Enable wayland by default, fallback to X11 (flathub#99)"

1c95b03

This reverts commit 1eef6b2.

evan-a-a added a commit to evan-a-a/com.bitwarden.desktop that referenced this pull request Nov 27, 2023

Revert "Enable wayland by default, fallback to X11 (flathub#99)"

bba7333

This reverts commit 1eef6b2.

RayJW mentioned this pull request Dec 5, 2023

Upscayl Flatpak crashes on launch on Wayland upscayl/upscayl#591

Closed

4 tasks

Enable wayland by default, fallback to X11 #99

Enable wayland by default, fallback to X11 #99

Conversation

ghisvail commented May 5, 2022

flathubbot commented May 5, 2022

flathubbot commented May 5, 2022

flathubbot commented May 9, 2022

flathubbot commented May 9, 2022

flathubbot commented Jun 3, 2022

flathubbot commented Jun 3, 2022

TheEvilSkeleton Jul 7, 2022

Choose a reason for hiding this comment

flathubbot commented Aug 15, 2022

flathubbot commented Aug 15, 2022

proletarius101 commented Dec 29, 2022

ghisvail commented Dec 29, 2022

flathubbot commented Dec 29, 2022

flathubbot commented Dec 29, 2022

flathubbot commented Dec 29, 2022

flathubbot commented Dec 29, 2022

flathubbot commented Jan 14, 2023

flathubbot commented Jan 14, 2023

flathubbot commented Jan 14, 2023

flathubbot commented Jan 14, 2023

flathubbot commented Jan 14, 2023

flathubbot commented Jan 14, 2023

flathubbot commented Jan 18, 2023

flathubbot commented Jan 18, 2023

taaem commented Sep 5, 2023

taaem commented Sep 5, 2023

ghisvail commented Sep 5, 2023

taaem commented Sep 5, 2023

taaem commented Sep 5, 2023

ghisvail commented Sep 5, 2023

flathubbot commented Sep 6, 2023

flathubbot commented Sep 6, 2023

flathubbot commented Sep 9, 2023

ghisvail commented Sep 9, 2023

flathubbot commented Sep 9, 2023

taaem commented Sep 11, 2023

cassidyjames commented Nov 8, 2023

flathubbot commented Nov 12, 2023

flathubbot commented Nov 12, 2023

ghisvail commented Nov 12, 2023