-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beta branch for arduino 2.0 #42
Conversation
Started test build 77902 |
Build 77902 failed |
Started test build 77904 |
Build 77904 successful
|
Thanks for your contribution. Looks interesting, Ill check it during the week. Since this is a new app, it might make sense to have it in a separate repository. |
Yeah I agree with you on this however I have never published a new app on flathub before I have only contributed. |
If we choose this direction I can take care of the process so don't worry about it. |
Makes sense. |
I'd just thought i'd update here and say that after some further testing (compiling and uploading code, using libraries saved in my sketchbook, signing into my arduino account inside the app) everything seems to be working as expected (i.e. a bug or two i hit was not flatpaks fault but a bug in the editor because of its release candidate state if that makes sense). |
…it wasn't installed. Added permissions for keychain access (as this is used), wayland access and notifications.
Started test build 77935 |
Build 77935 successful
|
Started test build 77941 |
Build 77941 successful
|
Started test build 77944 |
Build 77944 successful
|
Started test build 77946 |
Build 77946 successful
|
Unlike Arduino IDE 1.x, which bundles them in the installation, Arduino IDE 2.x automatically installs the fundamental libraries (e.g., Keyboard, Mouse, Servo) as well as the "Arduino AVR Boards" platform on the first run. |
Good to know i didnt include anything that wasn't needed. |
Turns out we need this This reverts commit d5e7fe2.
bot, build |
Queued test build for cc.arduino.arduinoide. |
The source of the new ide is not available? |
Build 87303 successful
|
Started test build 90499 |
Build 90499 successful
|
Started test build 92359 |
Build 92359 successful
|
This reverts commit 0c5fff8.
Zypak should work now meaning that --no-sandbox is nolonger needed still struggling with compile from source but i will get there in the future.
bot, build |
Queued test build for cc.arduino.arduinoide. |
Started test build 92470 |
Build 92470 successful
|
I have been thinking about this:
I'm thinking that is would be a good idea to create a new repository/app for the new version as there is a huge difference between the 2 versions and some people may want to use the old version. Edit: Also in case you missed i was recently able to get zypak working properly meaning that the package isn't using the |
I think it is the best option. If at some point the current Arduino app becomes deprecated we can wait a bit and then deprecate this repo (pointing to the new one).
Great, zypark is the only way atm to make electron apps work sandboxed. Yes building electron apps from source is hard and not something I can really help you with but I can ask around, we can start like this when submitting it. Do you have any idea when the app is going to be released? I see it is at rc6. Another thing to check is whether the repository upstream counts with the app icon, desktop file and metainfo/appdata so to use those instead. |
Started test build 92526 |
Build 92526 successful
|
The icon i pulled from within the build Edit: TBH i don't know when they plan on releasing the software or how long that could take. |
i am closing this pr as the v2 ide has been created as a separate flathub app. |
Congratulations and thanks for looking into it! |
On a side note, did you contact upstream? It would be good to keep them informed that the apps is being distributed and invite them to maintain (or co-maintain) the app. |
Yeah i reached out just to check to see if was ok. if they want to take over or contribute im obviously fine with that |
THIS NEEDS CHECKING AND PEER REVIEWING
I have been able to create a flatpak for v2.
To get the new version to run i had to disable the chrome sandbox (not sure if this will cause issues or not)
I haven't tested uploading any scripts yet or many main functions of arduino itself.I also didn't include any libraries into the flatpak like on the current branch (Edit: i personally didn't see them necessary, as libraries (and more) can be added in the sketchbook folder or are already included with the editor. It also helps keep the download lighter as the new version is quite large).
Obviously this needs committing into a beta branch which i couldn't select as there isn't one.
I
will do some more testing laterhave done some testing(and fixes if needed)but i would like to share my work.Edit: Update posted see this comment.
Addresses issue #29
Allow edits by maintainers is on.