Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Beta branch for arduino 2.0 #42

Closed
wants to merge 23 commits into from
Closed

Add Beta branch for arduino 2.0 #42

wants to merge 23 commits into from

Conversation

SuperNinja-4965
Copy link
Contributor

@SuperNinja-4965 SuperNinja-4965 commented Feb 9, 2022

THIS NEEDS CHECKING AND PEER REVIEWING

I have been able to create a flatpak for v2.
To get the new version to run i had to disable the chrome sandbox (not sure if this will cause issues or not)
I haven't tested uploading any scripts yet or many main functions of arduino itself.
I also didn't include any libraries into the flatpak like on the current branch (Edit: i personally didn't see them necessary, as libraries (and more) can be added in the sketchbook folder or are already included with the editor. It also helps keep the download lighter as the new version is quite large).
Obviously this needs committing into a beta branch which i couldn't select as there isn't one.

I will do some more testing later have done some testing (and fixes if needed) but i would like to share my work.
Edit: Update posted see this comment.

Addresses issue #29

Allow edits by maintainers is on.

@flathubbot
Copy link
Contributor

Started test build 77902

@flathubbot
Copy link
Contributor

Build 77902 failed

@flathubbot
Copy link
Contributor

Started test build 77904

@flathubbot
Copy link
Contributor

Build 77904 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/75777/cc.arduino.arduinoide.flatpakref

@A6GibKm
Copy link
Collaborator

A6GibKm commented Feb 9, 2022

Thanks for your contribution. Looks interesting, Ill check it during the week.

Since this is a new app, it might make sense to have it in a separate repository.

@SuperNinja-4965
Copy link
Contributor Author

Thanks for your contribution. Looks interesting, Ill check it during the week.

Since this is a new app, it might make sense to have it in a separate repository.

Yeah I agree with you on this however I have never published a new app on flathub before I have only contributed.
Should you choose to do that I'm willing to help and contribute with that.

@A6GibKm
Copy link
Collaborator

A6GibKm commented Feb 9, 2022

Thanks for your contribution. Looks interesting, Ill check it during the week.
Since this is a new app, it might make sense to have it in a separate repository.

Yeah I agree with you on this however I have never published a new app on flathub before I have only contributed. Should you choose to do that I'm willing to help and contribute with that.

If we choose this direction I can take care of the process so don't worry about it.

@SuperNinja-4965
Copy link
Contributor Author

Thanks for your contribution. Looks interesting, Ill check it during the week.
Since this is a new app, it might make sense to have it in a separate repository.

Yeah I agree with you on this however I have never published a new app on flathub before I have only contributed. Should you choose to do that I'm willing to help and contribute with that.

If we choose this direction I can take care of the process so don't worry about it.

Makes sense.

@SuperNinja-4965
Copy link
Contributor Author

I'd just thought i'd update here and say that after some further testing (compiling and uploading code, using libraries saved in my sketchbook, signing into my arduino account inside the app) everything seems to be working as expected (i.e. a bug or two i hit was not flatpaks fault but a bug in the editor because of its release candidate state if that makes sense).
For obvious reasons i still recommend that others do some testing but i'd thought id share my results here.

…it wasn't installed.

Added permissions for keychain access (as this is used), wayland access and notifications.
@flathubbot
Copy link
Contributor

Started test build 77935

@flathubbot
Copy link
Contributor

Build 77935 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/75807/cc.arduino.arduinoide.flatpakref

@flathubbot
Copy link
Contributor

Started test build 77941

@flathubbot
Copy link
Contributor

Build 77941 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/75812/cc.arduino.arduinoide.flatpakref

@flathubbot
Copy link
Contributor

Started test build 77944

@flathubbot
Copy link
Contributor

Build 77944 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/75815/cc.arduino.arduinoide.flatpakref

@flathubbot
Copy link
Contributor

Started test build 77946

@flathubbot
Copy link
Contributor

Build 77946 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/75817/cc.arduino.arduinoide.flatpakref

@per1234
Copy link

per1234 commented Feb 9, 2022

I also didn't include any libraries into the flatpak like on the current branch

Unlike Arduino IDE 1.x, which bundles them in the installation, Arduino IDE 2.x automatically installs the fundamental libraries (e.g., Keyboard, Mouse, Servo) as well as the "Arduino AVR Boards" platform on the first run.

@SuperNinja-4965
Copy link
Contributor Author

I also didn't include any libraries into the flatpak like on the current branch

Unlike Arduino IDE 1.x, which bundles them in the installation, Arduino IDE 2.x automatically installs the fundamental libraries (e.g., Keyboard, Mouse, Servo) as well as the "Arduino AVR Boards" platform on the first run.

Good to know i didnt include anything that wasn't needed.

Turns out we need this
This reverts commit d5e7fe2.
@SuperNinja-4965
Copy link
Contributor Author

bot, build

@flathubbot
Copy link
Contributor

Queued test build for cc.arduino.arduinoide.

@A6GibKm
Copy link
Collaborator

A6GibKm commented Feb 9, 2022

The source of the new ide is not available?

@flathubbot
Copy link
Contributor

Build 87303 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/85142/cc.arduino.arduinoide.flatpakref

@flathubbot
Copy link
Contributor

Started test build 90499

@flathubbot
Copy link
Contributor

Build 90499 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88284/cc.arduino.arduinoide.flatpakref

@flathubbot
Copy link
Contributor

Started test build 92359

@flathubbot
Copy link
Contributor

Build 92359 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/90088/cc.arduino.arduinoide.flatpakref

Zypak should work now meaning that --no-sandbox is nolonger needed
still struggling with compile from source but i will get there in the future.
@SuperNinja-4965
Copy link
Contributor Author

bot, build

@flathubbot
Copy link
Contributor

Queued test build for cc.arduino.arduinoide.

@flathubbot
Copy link
Contributor

Started test build 92470

@flathubbot
Copy link
Contributor

Build 92470 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/90201/cc.arduino.arduinoide.flatpakref

@SuperNinja-4965
Copy link
Contributor Author

SuperNinja-4965 commented May 20, 2022

I have been thinking about this:

Thanks for your contribution. Looks interesting, Ill check it during the week.

Since this is a new app, it might make sense to have it in a separate repository.

I'm thinking that is would be a good idea to create a new repository/app for the new version as there is a huge difference between the 2 versions and some people may want to use the old version.
What are your thoughts? I'm willing to handle the creation etc but i just wanted your opinion about this (if that makes any sense).

Edit: Also in case you missed i was recently able to get zypak working properly meaning that the package isn't using the --no-sandbox parameter.
I have been working on building from source but im having issues and the default build instructions aren't working/neither are the ones used in the nightly builds. And the fact that i dont have huge experience with compiling Electron/theia apps is slowing me down. I'll get it eventually but i dont have much free time now until july to look into it but for now downloading the pre-compiled binary works just fine and compiling from source is just an ideal.

@A6GibKm
Copy link
Collaborator

A6GibKm commented May 20, 2022

I'm thinking that is would be a good idea to create a new repository/app for the new version as there is a huge difference between the 2 versions and some people may want to use the old version.
What are your thoughts? I'm willing to handle the creation etc but i just wanted your opinion about this (if that makes any sense).

I think it is the best option. If at some point the current Arduino app becomes deprecated we can wait a bit and then deprecate this repo (pointing to the new one).

Also in case you missed i was recently able to get zypak working properly meaning that the package isn't using the --no-sandbox parameter.
I have been working on building from source but im having issues and the default build instructions aren't working/neither are the ones used in the nightly builds. And the fact that i dont have huge experience with compiling Electron/theia apps is slowing me down. I'll get it eventually but i dont have much free time now until july to look into it but for now downloading the pre-compiled binary works just fine and compiling from source is just an ideal.

Great, zypark is the only way atm to make electron apps work sandboxed. Yes building electron apps from source is hard and not something I can really help you with but I can ask around, we can start like this when submitting it. Do you have any idea when the app is going to be released? I see it is at rc6.

Another thing to check is whether the repository upstream counts with the app icon, desktop file and metainfo/appdata so to use those instead.

@flathubbot
Copy link
Contributor

Started test build 92526

@flathubbot
Copy link
Contributor

Build 92526 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/90256/cc.arduino.arduinoide.flatpakref

@SuperNinja-4965
Copy link
Contributor Author

SuperNinja-4965 commented May 20, 2022

I'm thinking that is would be a good idea to create a new repository/app for the new version as there is a huge difference between the 2 versions and some people may want to use the old version.
What are your thoughts? I'm willing to handle the creation etc but i just wanted your opinion about this (if that makes any sense).

I think it is the best option. If at some point the current Arduino app becomes deprecated we can wait a bit and then deprecate this repo (pointing to the new one).

Also in case you missed i was recently able to get zypak working properly meaning that the package isn't using the --no-sandbox parameter.
I have been working on building from source but im having issues and the default build instructions aren't working/neither are the ones used in the nightly builds. And the fact that i dont have huge experience with compiling Electron/theia apps is slowing me down. I'll get it eventually but i dont have much free time now until july to look into it but for now downloading the pre-compiled binary works just fine and compiling from source is just an ideal.

Great, zypark is the only way atm to make electron apps work sandboxed. Yes building electron apps from source is hard and not something I can really help you with but I can ask around, we can start like this when submitting it. Do you have any idea when the app is going to be released? I see it is at rc6.

Another thing to check is whether the repository upstream counts with the app icon, desktop file and metainfo/appdata so to use those instead.

The icon i pulled from within the build so i'll update the build commands to get it from there, i dont think they have a desktop file or metainfo file in the repo/builds yet but i will check

Edit: TBH i don't know when they plan on releasing the software or how long that could take.
Edit2: Actually i dont think we can use their image because it is the wrong resolution. i had to scale it down to meet flatpak's requirements.

@SuperNinja-4965
Copy link
Contributor Author

i am closing this pr as the v2 ide has been created as a separate flathub app.
thanks to those who helped with this.

@A6GibKm
Copy link
Collaborator

A6GibKm commented May 30, 2022

Congratulations and thanks for looking into it!

@A6GibKm
Copy link
Collaborator

A6GibKm commented May 30, 2022

On a side note, did you contact upstream? It would be good to keep them informed that the apps is being distributed and invite them to maintain (or co-maintain) the app.

@SuperNinja-4965
Copy link
Contributor Author

arduino/arduino-ide#1001

@SuperNinja-4965
Copy link
Contributor Author

Yeah i reached out just to check to see if was ok. if they want to take over or contribute im obviously fine with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants