release action: Create new release from list, include old release #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the release GitHub Actions workflow to build a new release instead of modifying an existing one. The previous "latest" release will be deleted. The release will contain all sysexts listed in "release_build_versions.txt" as well as all sysexts included in the previous latest release. It will generate a Release.md to be included in the release. The change also updates the workflow to only run when the tag "latest" is pushed. Signed-off-by: Thilo Fromm <[email protected]>
|
(I'm not around for more than a week, feel free to amend and merge this PR as you see fit) |
pothos
reviewed
Feb 12, 2024
| @@ -2,7 +2,7 @@ name: Build and release Systemd sysext images | |||
| on: | |||
| push: | |||
| tags: | |||
| - '*' | |||
| - 'latest' | |||
There was a problem hiding this comment.
Improvement: Also release on a weekly cadence
There was a problem hiding this comment.
Ah, and should we always release main? Maybe a new action could run on every push and create a latest tag and trigger this action here (I think it won't get invoked by another workflow as this is a mechanism to prevent recursion).
There was a problem hiding this comment.
Eventually, yes. For this (and the weekly build cadence) to add value we should first make the build auto-detect new versions for all sysexts (like it does for Kubernetes already): I've opened a tracking issue for that: #42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the release GitHub Actions workflow to build a new release instead of modifying an existing one. The previous "latest" release will be deleted.
The release will contain all sysexts listed in
"release_build_versions.txt" as well as all sysexts included in the previous latest release. It will generate a Release.md to be included in the release.
The change also updates the workflow to only run when the tag "latest" is pushed.