readme: add example to use release artifacts #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
reviewed
Aug 3, 2023
| - path: /opt/extensions/kubernetes/kubernetes-v1.27.4.raw | ||
| contents: | ||
| source: https://github.com/flatcar/sysext-bakery/releases/latest/download/kubernetes-v1.27.4.raw | ||
| - path: /etc/systemd/system-generators/torcx-generator |
There was a problem hiding this comment.
Yes, it's a "hack" around the torcx-generator to prevent it to run. Otherwise Torcx unpacks containerd.service and docker.{service,socket} under /run/systemd/system/ which takes precedence over /usr/lib/systemd/system/docker.{service,socket} and /usr/lib/systemd/system/containerd.service merged by systemd-sysext.
Which leads to this weird situation:
$ docker version
Client:
Version: 24.0.5
API version: 1.41 (downgraded from 1.43)
Go version: go1.20.6
Git commit: ced0996
Built: Fri Jul 21 20:34:32 2023
OS/Arch: linux/amd64
Context: default
Server:
Engine:
Version: 20.10.24
API version: 1.41 (minimum version 1.12)
...
pothos
reviewed
Aug 3, 2023
README.md
Outdated
| files: | ||
| - path: /opt/extensions/docker/docker-24.0.5.raw | ||
| contents: | ||
| source: https://github.com/flatcar/sysext-bakery/releases/latest/download/docker-24.0.5.raw |
There was a problem hiding this comment.
Latest would break, I think we should use a versioned release URL here.
pothos
reviewed
Aug 3, 2023
pothos
approved these changes
Aug 3, 2023
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #16