-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys-kernel/bootengine: Bump to fix slow PXE/ISO boots with udev rule #2249
Conversation
sdk_container/src/third_party/coreos-overlay/sys-kernel/bootengine/bootengine-9999.ebuild
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tip: I usually avoid using Closes:
tags in commit messages/PRs, and prefer cross-referencing with See:
. The issue has now been closed even though we haven't merged the scripts PR yet. Even after this PR is merged, we'd still need to backport to stable-3975 (because that's where the issue was spotted) before we can consider the issue closed. Sometimes it even makes sense to wait until a release has been done.
See: flatcar/bootengine#98 See: flatcar/Flatcar#1514 Signed-off-by: James Le Cuirot <[email protected]>
18ff8e3
to
401a715
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this needs backporting to other channels, make sure you don't backport additional changes in bootengine by accident. If other channels were using different commit for bootengine, we will need to create backport branches in baselayout that contain your fix only.
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10955901407 |
sys-kernel/bootengine: Bump to fix slow PXE/ISO boots with udev rule
I just noticed that this change has been backported to the previous beta (flatcar-4012) but we forgot to backport it on previous alpha (flatcar-4054) which has been promoted to current beta - we might need to backport it again to current beta (flatcar-4054) in case we push a maintenance release for beta channel. |
Oh, sorry about that. Still getting my head around this. |
Cherry-picked to flatcar-4054 |
Cherry-picked to flatcar-3975 as well. |
sys-kernel/bootengine: Bump to fix slow boots with udev rule
See: flatcar/bootengine#98
See: flatcar/Flatcar#1514
How to use
See: flatcar/bootengine#98
Testing done
Lots of manual testing and a packages_all_arches Jenkins job, as mentioned in the other PR. I'll do a GitHub run for this PR.
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.