sys-apps/baselayout: Don't fetch non-live version from git #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a regular tarball from GitHub. baselayout is a special case because Catalyst initially installs it with --nodeps. We currently use stage 4 as a seed, which includes git, so this is fine right now, but we would like to switch to using stage 3 instead. You also might use a cross-compiled stage 3 as a seed when porting the SDK to a new architecture. Signed-off-by: James Le Cuirot <[email protected]>
krnowak
approved these changes
Aug 16, 2024
sdk_container/src/third_party/coreos-overlay/sys-apps/baselayout/baselayout-9999.ebuild
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys-apps/baselayout: Don't fetch non-live version from git
Use a regular tarball from GitHub. baselayout is a special case because Catalyst initially installs it with
--nodeps. We currently use stage 4 as a seed, which includes git, so this is fine right now, but we would like to switch to using stage 3 instead. You also might use a cross-compiled stage 3 as a seed when porting the SDK to a new architecture.For the switch to stage 3, I had initially wanted to publish the tarball with a different filename, but this has proved super awkward due to the digest check. baselayout is the only thing preventing this change from being backwards-compatible. Rather than change the filename, I am getting this baselayout change in well ahead of the switch to avoid breaking current development branches. Only the SDK build would break though, which isn't something we typically do outside CI, and simply rebasing will fix it.
How to use
Nothing to use here.
Testing done
I've done a two-phase Jenkins run. There were no notable changes.
changelog/directory (user-facing change, bug fix, security fix, update) -- N/A/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.