-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python tests from GCE and Azure OEM images and python sysext #2230
Conversation
Not only python is being installed, but also some extra packages like setuptools. These amount of tests seems to be growing, which is not a bad thing per se, but we really don't need them in the GCE OEM sysext.
Do the same thing we did for GCE.
Do the same thing we did for GCE and Azure.
@chewi mentioned in #2227 (comment) that Gentoo installs the python tests even on installation media, because apparently some libraries expect those files to exist and there's no way to tell which files are those. I suppose we could try removing them and maybe bringing them back if it breaks something? |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10740695721 |
Looking at Gentoo bug #531648, it seems these are only used by other test suites, including some from third-party libraries. We probably don't want to support end users running any Python test suites on Flatcar, even third-party ones. |
This seems to reduce the size of sysext images by about 15MB:
This means that azure and gce production images shrunk by about 15MB too. That being said, either the compression rate of squashfs is impressive or the reports' size calculation is botched, because in the reports it is stated that the size of deleted files is 193MB for Azure and GCE. Also noticed that reports are not handling the other sysexts we generate (python, zfs, podman and stuff). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect those files compress very well.
Addressed by flatcar/flatcar-build-scripts#162 and #2236. |
Just an FYI, Gentoo has now split out these tests into a separate package so that they only get pulled in by the packages that actually need them. |
Thanks for letting me know. I can see that it was done for the dev-lang/python. But do other python packages still install their tests? |
I hadn't considered other packages. I can see even Portage does that. My bad, I could have improved that when I migrated it to Meson. 😅 At least the space taken up by these is relatively small compared to what Python itself installed. |
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/4491/cldsv/
We used to drop them for GCE, but after converting to sysext, this change was dropped.
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.