Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #1751

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Small fixes #1751

merged 4 commits into from
Mar 15, 2024

Conversation

jepio
Copy link
Member

@jepio jepio commented Mar 14, 2024

Small fixes

  • install terminfo files for tmux
  • slightly speed up ./build_image by using lbzip2 instead of bzip2 when decompressing gcc.tbz2

How to use

[ describe what reviewers need to do in order to validate this PR ]

Testing done

[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

jepio added 2 commits March 14, 2024 17:18
Debian tmux seems to set TERM=tmux-256color, not TERM=screen. This
causes issues when ssh-ing into flatcar from tmux. Copy the screen
terminfo files as the tmux ones, they should be mostly compatible.

Tmux terminfo files are removed because of USE=minimal, but I don't see
a way to hook into the ebuild and prevent the removal easily.

Signed-off-by: Jeremi Piotrowski <[email protected]>
Speeds things up a bit.

Signed-off-by: Jeremi Piotrowski <[email protected]>
@jepio jepio requested a review from a team March 14, 2024 18:02
Copy link

github-actions bot commented Mar 14, 2024

Mksquashfs running against a btrfs filesystem tries to capture btrfs specific
xattrs (btrfs.compression) generating a lot of spam. Remove the spam by
ignoring btrfs xattrs.

Signed-off-by: Jeremi Piotrowski <[email protected]>
Copy link
Member Author

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pothos added two more commits (silence xattr spam in cpio build and add --pull always). Can you take another look?

Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jepio
Copy link
Member Author

jepio commented Mar 15, 2024

Build passed, merging.

@jepio
Copy link
Member Author

jepio commented Mar 15, 2024

@jepio jepio merged commit dc71208 into main Mar 15, 2024
1 check failed
@jepio jepio deleted the jepio/fixes branch March 15, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants