Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform: add scaleway platform #501

Merged
merged 8 commits into from
Apr 12, 2024
Merged

platform: add scaleway platform #501

merged 8 commits into from
Apr 12, 2024

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Feb 19, 2024

In this PR, we add the Scaleway provider support to Mantle.

How to use

In the same spirit of Brightbox or OpenStack:

wget https://alpha.release.flatcar-linux.net/amd64-usr/current/flatcar_production_scaleway_image.img.bz2
bzip2 -dk ./flatcar_production_scaleway_image.img.bz2
mv flatcar_production_scaleway_image.{img,qcow2}

SCALEWAY_ACCESS_KEY=
SCALEWAY_SECRET_KEY=
SCALEWAY_ORGANIZATION_ID=
SCALEWAY_PROJECT_ID=

IMAGE_ID=$(./bin/ore scaleway \
  --scaleway-access-key "${SCALEWAY_ACCESS_KEY}" \
  --scaleway-secret-key "${SCALEWAY_SECRET_KEY}" \
  --scaleway-organization-id "${SCALEWAY_ORGANIZATION_ID}" \
  create-image)

./bin/kola --parallel 1 --platform scaleway \
  --scaleway-image "${IMAGE_ID}" \
  --scaleway-project-id "${SCALEWAY_PROJECT_ID}" \
  --scaleway-organization-id "${SCALEWAY_ORGANIZATION_ID}" \
  --scaleway-access-key "${SCALEWAY_ACCESS_KEY}" \
  --scaleway-secret-key "${SCALEWAY_SECRET_KEY}" \
  run kubeadm.v1.29.2.cilium.base

Notes for reviewers

  • the inheritance of the AWS API in the Scaleway API is far from being ideal but it avoids code duplication

@tormath1 tormath1 self-assigned this Feb 19, 2024
@tormath1 tormath1 force-pushed the tormath1/scaleway branch 2 times, most recently from f93a3ab to 3a46e08 Compare February 19, 2024 15:51
@tormath1 tormath1 force-pushed the tormath1/scaleway branch 2 times, most recently from 423c0ed to 2f31317 Compare March 6, 2024 09:28
@tormath1 tormath1 force-pushed the tormath1/scaleway branch 2 times, most recently from 4b22373 to a69e024 Compare April 9, 2024 16:02
@tormath1 tormath1 marked this pull request as ready for review April 9, 2024 16:12
@tormath1 tormath1 requested a review from a team April 9, 2024 16:12
cmd/ore/scaleway/create-image.go Outdated Show resolved Hide resolved
platform/api/scaleway/instance.go Outdated Show resolved Hide resolved
platform/api/scaleway/instance.go Outdated Show resolved Hide resolved
platform/api/scaleway/instance.go Show resolved Hide resolved
platform/machine/scaleway/cluster.go Outdated Show resolved Hide resolved
platform/machine/scaleway/cluster.go Show resolved Hide resolved
platform/api/scaleway/api.go Show resolved Hide resolved
platform/machine/scaleway/machine.go Outdated Show resolved Hide resolved
@krnowak
Copy link
Member

krnowak commented Apr 12, 2024

Please squash the fixup commits before merge.

Doing this, we prepare the landing of Scaleway provider and leverage the
existing S3 AWS methods.

Signed-off-by: Mathieu Tortuyaux <[email protected]>
It changes nothing except for Scaleway: we get an error 400 if we try to
set even an empty ACL.

Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 force-pushed the tormath1/scaleway branch from 38d0c86 to 490eacb Compare April 12, 2024 12:13
@tormath1 tormath1 merged commit d34ff9a into flatcar-master Apr 12, 2024
2 checks passed
@tormath1 tormath1 deleted the tormath1/scaleway branch April 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants