workflow: add additional images to mirror #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed in the calico logs: ``` pod_workers.go:965] "Error syncing pod, skipping" err="[failed to \"StartContainer\" for \"calico-csi\" with ImagePullBackOff: \"Back-off pulling image \\\"ghcr.io/flatcar/calico/csi:v3.26.3\\\"\", failed to \"StartContainer\" for \"csi-node-driver-registrar\" with ImagePullBackOff: \"Back-off pulling image \\\"ghcr.io/flatcar/calico/node-driver-registrar:v3.26.3\\\"\"]" pod="calico-system/csi-node-driver-gdhcm" podUID=05b7a8ec-7d12-486a-b6a2-87388a502d4a ``` projectcalico/calico@9d39763 might be related? But not sure since it's present since the release 3.25.0 Signed-off-by: Mathieu Tortuyaux <[email protected]>
krnowak
approved these changes
Nov 10, 2023
|
I think you could kick off this job after merging it. |
|
I had to hack a bit the workflow: diff --git a/.github/workflows/sync-calico-version.yml b/.github/workflows/sync-calico-version.yml
index 0cfd0599..662c663c 100644
--- a/.github/workflows/sync-calico-version.yml
+++ b/.github/workflows/sync-calico-version.yml
@@ -35,15 +35,13 @@ jobs:
commit-message: Update calico to ${{ steps.update-links.outputs.CALICO_VERSION }}
delete-branch: true
- name: Login to GitHub Container Registry (ghcr)
- if: steps.update-links.outputs.UPDATE_NEEDED == 1
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Mirror calico images to GHCR
- if: steps.update-links.outputs.UPDATE_NEEDED == 1
env:
- CALICO_VERSION: ${{ steps.update-links.outputs.CALICO_VERSION }}
+ CALICO_VERSION: v3.26.3
GHCR_ORG: ${{ inputs.ghcr_org }}
run: .github/workflows/mirror-calico-images.sh "${GHCR_ORG:-flatcar}" "${CALICO_VERSION}"Otherwise the mirroring is ignored if there is no new version. Here's the resulting action: Images are now available: https://github.com/orgs/flatcar/packages?tab=packages&q=calico |
|
That's acceptable since it was just a one-off. Thanks for doing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in the calico logs:
projectcalico/calico@9d39763 might be related? But not sure since it's present since the release 3.25.0
That should help reducing the flaky tests.