Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the batch size/seq len args for the decode kernel with tensor cores #640

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix the batch size/seq len args for the decode kernel with tensor cores #640

merged 1 commit into from
Nov 26, 2024

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Nov 26, 2024

A prior PR switched up the two arguments via a typo, without tests catching the problem.

@nandor
Fix the batch size/seq len args for the decode kernel with tensor cores
841df89 
A prior PR switched up the two arguments via a typo, without tests catching the problem.
yzh119
yzh119 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch.

@yzh119 yzh119 merged commit 42b9874 into flashinfer-ai:main Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzh119 yzh119 yzh119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nandor @yzh119