Add verifications in getHeader handler #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Georges Francois <[email protected]>
metachris
reviewed
Jun 30, 2022
metachris
reviewed
Jun 30, 2022
server/service.go
Outdated
| @@ -20,6 +20,7 @@ import ( | |||
| var ( | |||
| errInvalidSlot = errors.New("invalid slot") | |||
| errInvalidHash = errors.New("invalid hash") | |||
| errInvalidParentHash = errors.New("invalid parent hash") | |||
There was a problem hiding this comment.
let's remove that if it's only used in the error message, to avoid accumulating unnecessary things
metachris
reviewed
Jun 30, 2022
server/service.go
Outdated
| @@ -279,6 +280,12 @@ func (m *BoostService) handleGetHeader(w http.ResponseWriter, req *http.Request) | |||
| return | |||
| } | |||
|
|
|||
| // Verify response coherence with proposer's input data | |||
| if responsePayload.Data != nil && responsePayload.Data.Message.Header.ParentHash.String() != parentHashHex { | |||
| log.WithError(errInvalidParentHash).Error("proposer and relay parent hashes are not the same") | |||
There was a problem hiding this comment.
maybe could add the relevant fields to the message (log.WithFields)
|
great, thanks! |
Co-authored-by: Chris Hager <[email protected]>
Signed-off-by: Luca Georges Francois <[email protected]>
|
ty |
screwyprof
pushed a commit
to screwyprof/mev-boost
that referenced
this pull request
Feb 3, 2023
* Add parent hash verification in getHeader Signed-off-by: Luca Georges Francois <[email protected]> * Remove unnecessary nil check Co-authored-by: Chris Hager <[email protected]> * Update error log in getHeader handler Signed-off-by: Luca Georges Francois <[email protected]> Co-authored-by: Chris Hager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR adds the following verification(s) in the
getHeaderhandler :parent_hashin the response (given by the relay) is the same as the one in the request (the one given by the proposer)public_keyin the response is the same as the one in the requestIt closes #174.
⛱ Motivation and Context
More context about this PR can be found in #174.
📚 References
The
getHeaderhandler is defined here✅ I have run these commands
make lintmake testmake run-mergemock-integrationgo mod tidy