Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid translation key for scheduler dashboard #3736

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: invalid translation key for scheduler dashboard #3736

merged 1 commit into from
Feb 16, 2023

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented Feb 15, 2023

Fix #3697

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@rob006 rob006 requested a review from a team as a code owner February 15, 2023 18:43
@luceos luceos merged commit 0da069b into flarum:main Feb 16, 2023
@luceos
Copy link
Member

luceos commented Feb 16, 2023

Thank you, great find!

@rob006 rob006 deleted the scheduler-translation branch February 16, 2023 18:42
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luceos luceos luceos requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing translation core.admin.status.scheduler.inactive
2 participants
@rob006 @luceos