Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seo): shift h1 tag from logo to discussion title #3724

Merged
merged 4 commits into from
Feb 11, 2023
Merged

feat(seo): shift h1 tag from logo to discussion title #3724

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2c1cfc
feat(seo): shift h1 tag from logo to discussion title
luceos Jan 22, 2023
4382657
feat(seo): rewrite remainder of hero titles and subtitles
luceos Jan 22, 2023
ea1717a
Update extensions/tags/views/frontend/content/tag.blade.php
luceos Jan 22, 2023
c0482ac
Update framework/core/js/src/forum/components/WelcomeHero.tsx
luceos Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/package-manager/js/src/admin/components/ControlSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default class ControlSection extends Component<ComponentAttrs> {
<div className="ExtensionPage-permissions PackageManager-controlSection">
<div className="ExtensionPage-permissions-header">
<div className="container">
<h2 className="ExtensionTitle">{app.translator.trans('flarum-package-manager.admin.sections.control.title')}</h2>
<h1 className="ExtensionTitle">{app.translator.trans('flarum-package-manager.admin.sections.control.title')}</h1>
</div>
</div>
<div className="container">
Expand Down
2 changes: 1 addition & 1 deletion extensions/package-manager/js/src/admin/components/QueueSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default class QueueSection extends Component<{}> {
<section id="PackageManager-queueSection" className="ExtensionPage-permissions PackageManager-queueSection">
<div className="ExtensionPage-permissions-header PackageManager-queueSection-header">
<div className="container">
<h2 className="ExtensionTitle">{app.translator.trans('flarum-package-manager.admin.sections.queue.title')}</h2>
<h1 className="ExtensionTitle">{app.translator.trans('flarum-package-manager.admin.sections.queue.title')}</h1>
<Button
className="Button Button--icon"
icon="fas fa-sync-alt"
Expand Down
4 changes: 2 additions & 2 deletions extensions/tags/js/src/forum/components/TagHero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ export default class TagHero extends Component {
>
<div className="container">
<div className="containerNarrow">
<h2 className="Hero-title">
<h1 className="Hero-title">
{tag.icon() && tagIcon(tag, {}, { useColor: false })} {tag.name()}
</h2>
</h1>
<div className="Hero-subtitle">{tag.description()}</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions extensions/tags/views/frontend/content/tag.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
@inject('url', 'Flarum\Http\UrlGenerator')

<div class="container">
<h2>{{ $tag->name }}</h2>
<p>{{ $tag->description }}</p>
<h1>{{ $tag->name }}</h1>
<h2>{{ $tag->description }}</h2>
luceos marked this conversation as resolved.
Show resolved Hide resolved

<ul>
@foreach ($apiDocument->data as $discussion)
Expand Down
2 changes: 1 addition & 1 deletion extensions/tags/views/frontend/content/tags.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@inject('url', 'Flarum\Http\UrlGenerator')

<div class="container">
<h2>{{ $translator->trans('flarum-tags.forum.index.tags_link') }}</h2>
<h1>{{ $translator->trans('flarum-tags.forum.index.tags_link') }}</h1>

@foreach ([$primaryTags, $secondaryTags] as $category)
<ul>
Expand Down
4 changes: 2 additions & 2 deletions framework/core/js/src/admin/components/AdminHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ export default class AdminHeader extends Component {
return [
<div className={classList(['AdminHeader', this.attrs.className])}>
<div className="container">
<h2>
<h1>
{icon(this.attrs.icon)}
{vnode.children}
</h2>
</h1>
<div className="AdminHeader-description">{this.attrs.description}</div>
</div>
</div>,
Expand Down
4 changes: 2 additions & 2 deletions framework/core/js/src/admin/components/ExtensionPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default class ExtensionPage<Attrs extends ExtensionPageAttrs = ExtensionP
{this.extension.icon ? icon(this.extension.icon.name) : ''}
</span>
<div className="ExtensionName">
<h2>{this.extension.extra['flarum-extension'].title}</h2>
<h1>{this.extension.extra['flarum-extension'].title}</h1>
</div>
<div className="ExtensionPage-headerTopItems">
<ul>{listItems(this.topItems().toArray())}</ul>
Expand Down Expand Up @@ -115,7 +115,7 @@ export default class ExtensionPage<Attrs extends ExtensionPageAttrs = ExtensionP
<div className="ExtensionPage-permissions">
<div className="ExtensionPage-permissions-header">
<div className="container">
<h2 className="ExtensionTitle">{app.translator.trans('core.admin.extension.permissions_title')}</h2>
<h1 className="ExtensionTitle">{app.translator.trans('core.admin.extension.permissions_title')}</h1>
</div>
</div>
<div className="container">
Expand Down
4 changes: 2 additions & 2 deletions framework/core/js/src/forum/components/UserCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default class UserCard extends Component {
: ''}

<div className="UserCard-profile">
<h2 className="UserCard-identity">
<h1 className="UserCard-identity">
{this.attrs.editable ? (
[AvatarEditor.component({ user, className: 'UserCard-avatar' }), username(user)]
) : (
Expand All @@ -58,7 +58,7 @@ export default class UserCard extends Component {
{username(user)}
</Link>
)}
</h2>
</h1>

{badges.length ? <ul className="UserCard-badges badges">{listItems(badges)}</ul> : ''}

Expand Down
4 changes: 2 additions & 2 deletions framework/core/js/src/forum/components/WelcomeHero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ export default class WelcomeHero extends Component<IWelcomeHeroAttrs> {
/>

<div class="containerNarrow">
<h2 class="Hero-title">{app.forum.attribute('welcomeTitle')}</h2>
<div class="Hero-subtitle">{m.trust(app.forum.attribute('welcomeMessage'))}</div>
<h1 class="Hero-title">{app.forum.attribute('welcomeTitle')}</h1>
<h2 class="Hero-subtitle">{m.trust(app.forum.attribute('welcomeMessage'))}</h2>
SychO9 marked this conversation as resolved.
Show resolved Hide resolved
</div>
</div>
</header>
Expand Down