feat: add JSON request/response support #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
seqre
approved these changes
Nov 27, 2024
flareon/src/response.rs
Outdated
| ); | ||
| match &response.body().inner { | ||
| BodyInner::Fixed(fixed) => { | ||
| assert_eq!(fixed, "{\"hello\":\"world\"}"); |
There was a problem hiding this comment.
Nit: in another place, we're using r#"{"hello":"world"}"# for that case. It would be nice to represent it in one way
| *request.body_mut() = Body::fixed(json_data.clone()); | ||
| request.headers_mut().insert( | ||
| http::header::CONTENT_TYPE, | ||
| http::HeaderValue::from_static("application/json"), |
There was a problem hiding this comment.
Why not use flareon::headers::JSON_CONTENT_TYPE?
There was a problem hiding this comment.
Just a good practice not to use any data used by production code in tests. This might be overdoing stuff (after all, it's just a well-known constant), but this prevents tests from passing when, for instance, the constant would be refactored and modified by a mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.