Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Go hook registration #187

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Fixed Go hook registration #187

merged 1 commit into from
Apr 5, 2021

Conversation

zuzzas
Copy link
Contributor

@zuzzas zuzzas commented Apr 3, 2021

Overview

What this PR does / why we need it

  • fix panic caused by the absent rate limiter
  • Metadata is calculated on sdk.Register call
  • simplification: sdk.Register call and a hook's structure should be in the same file

Special notes for your reviewer

Does this PR introduce a user-facing change?


@zuzzas zuzzas marked this pull request as ready for review April 3, 2021 11:27
@zuzzas zuzzas requested review from diafour and nabokihms April 3, 2021 11:27
@zuzzas zuzzas force-pushed the fix-go-hooks-registration branch 2 times, most recently from 24be609 to ec29765 Compare April 3, 2021 11:42
sdk/registry.go Outdated Show resolved Hide resolved
@zuzzas zuzzas force-pushed the fix-go-hooks-registration branch from ec29765 to fa81dd9 Compare April 3, 2021 12:01
sdk/registry.go Outdated Show resolved Hide resolved
sdk/registry.go Outdated Show resolved Hide resolved
sdk/registry.go Show resolved Hide resolved
@zuzzas zuzzas force-pushed the fix-go-hooks-registration branch 2 times, most recently from 3afa195 to 391ec82 Compare April 5, 2021 06:22
@zuzzas zuzzas requested a review from nabokihms April 5, 2021 06:28
@zuzzas zuzzas force-pushed the fix-go-hooks-registration branch 3 times, most recently from 77405ce to 3c5a99a Compare April 5, 2021 07:43
@zuzzas zuzzas force-pushed the fix-go-hooks-registration branch from 3c5a99a to 44a6223 Compare April 5, 2021 07:59
Copy link
Contributor

@diafour diafour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diafour diafour merged commit 06119d4 into master Apr 5, 2021
@zuzzas zuzzas deleted the fix-go-hooks-registration branch April 5, 2021 09:17
@diafour diafour added this to the 1.0.0 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants