Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying name, namespace and order for the module #39

Open
dmgtn opened this issue Aug 18, 2019 · 0 comments
Open

Allow specifying name, namespace and order for the module #39

dmgtn opened this issue Aug 18, 2019 · 0 comments
Assignees
Milestone

Comments

@dmgtn
Copy link
Member

dmgtn commented Aug 18, 2019

Problems:

  1. We automatically camel-case module name, but if the module name has some abbreviation – we get ugly things, like getting nodeLocalDns, instead of 'nodeLocalDNS`.
  2. Sometimes we need to know module namespace, but we don't have centralized mapping.
  3. It would be generally better if we will pass namespace to helm install, at least:
    • we will have namespaces in helm list,
    • we will be able to use Release.Namespace, instead of hardcoding namespace name into each template.
  4. Module order is part of ugly hardcode.

Proposal:

  1. Add module.yaml to each module, and make it required. It should contain, at least, name (camel-cased), namespace and order, all required.
  2. Use name (camel-cased) from module.yaml when generating helm values, and in all other places (list of enabled modules, logs, etc).
  3. Add the automagic global variable with module-to-namespace mapping.

Extra logic:

  1. When namespace of the module is changed – perhaps the module should be uninstalled first (as far I remember helm doesn't allow changing namespace for the installed release).
  2. When module name changes, for addon-operator it should be similar to one module gone, and a new one added.
@dmgtn dmgtn assigned dmgtn and diafour and unassigned dmgtn Aug 18, 2019
@dmgtn dmgtn changed the title Allow specifying name and namespace for the module Allow specifying name, namespace and order for the module Aug 19, 2019
@diafour diafour added this to the v2 milestone Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants