Refactor: Rename SetUpNetlinkTest to TestSetUpNetlink for consistency #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pkg/ns/ns.go, which is a test file, the function SetUpNetlinkTest is actually a test case. To adhere to Go's testing framework conventions and improve code readability, we rename it to TestSetUpNetlink. The previous name did not follow the standard naming convention for test functions, which should start with 'Test' to be recognized by the testing framework. Changes: - Renamed SetUpNetlinkTest to TestSetUpNetlink. - Updated the function signature to match Go's testing framework requirements (no return value). Signed-off-by: mahmut <[email protected]>
|
Are you sure about this? I understood that Go naming convention states that files with test functions should end with "_test.go". Example: https://go.dev/doc/tutorial/add-a-test |
|
Thanks for pointing that out! According to Go's naming conventions, test files should indeed end with _test.go. I'll double-check and ensure all test files follow this convention. If there are any discrepancies, I'll fix them promptly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pkg/ns/ns.go, which is a test file, the function SetUpNetlinkTest is actually a test case. To adhere to Go's testing framework conventions and improve code readability, we rename it to TestSetUpNetlink.
The previous name did not follow the standard naming convention for test functions, which should start with 'Test' to be recognized by the testing framework.
Changes:
Description
Todos
Release Note