Windows "host-gw" & "vxlan" support #1042
Conversation
thxCode
force-pushed
the
windows_support
branch
3 times, most recently
from
5fb56d3 to
2eee498
Compare
|
|
@madhanrm to review |
|
@thxCode @rakelkar I was testing my cluster setup ( AWS, Windows_Server-1803-English-Core-Containers, flannel host-gw) with PR #921 . I found management IP will not show up for newly created subnet unless X.X.X.2 endpoint been created and attached to host. I made some changes here song-jiang@d8c0eac with which the management ip issue has been fixed. So my question is
Thanks. |
thxCode
force-pushed
the
windows_support
branch
from
2eee498 to
8b9407c
Compare
|
@rajatchopra , addressed |
thxCode
force-pushed
the
windows_support
branch
from
8b9407c to
6a0758b
Compare
Yeah, I am fairly certain this is the same code just with some of the feedback from that and this thread addressed. If people care about keeping those original commits in the history I'd be happy to send another PR, but if it's all the same I'd just move ahead with this one. |
|
@benmoss yes we are working with @rajatchopra @tomdee to merge this PR and there are some followup fixes we need to make to make this code work. Kalya can generate them as soon as this PR is merged. |
backend/hostgw/hostgw_windows.go
Outdated
| log.Infof("Attached bridge endpoint %s to host successfully", bridgeEndpointName) | ||
|
|
||
| // 7. Enable forwarding on the host interface and endpoint | ||
| for _, interfaceIpAddress := range []string{expectedNetwork.ManagementIP, existingBridgeEndpoint.IPAddress.String()} { |
There was a problem hiding this comment.
existingBridgeEndpoint is now null since it is not in line 213
There was a problem hiding this comment.
@thxCode Can you please take care of this feedback comment? This is ready to merge.
There was a problem hiding this comment.
@rajatchopra , @ksubrmnn Addressed.
- update vendors
(*) github.com/Microsoft/hcsshim
(*) github.com/rakelkar/gonetsh
(*) github.com/Microsoft/go-winio
(*) github.com/sirupsen/logrus
(*) github.com/buger/jsonparser
- update Markfile
Co-authored-by: rakelkar <[email protected]>
Co-authored-by: madhanrm <[email protected]>
- Add Windows host-gw
(*) patch for flannel-io#921
- Add windows vxlan
(*) patch for flannel-io#922
Co-authored-by: rakelkar <[email protected]>
Co-authored-by: madhanrm <[email protected]>
thxCode
force-pushed
the
windows_support
branch
from
6a0758b to
e6fc2a2
Compare
|
@madhanrm , Added. |
|
@ksubrmnn We need a final lgtm from you. |
|
@rajatchopra will update after validating |
|
@rajatchopra LGTM |
|
Drum roll... merge!! |
Description
A patch PR for #921 & #922
Todos