Fixed crash selecting texttool #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borgmanJeremy
approved these changes
Feb 5, 2022
|
Thank you! I was struggling to find a fix for this. |
|
is this merged with latest release? I'm having the said fixed issue |
|
@fuzunspm No, this was merged on 2022-02-05 and the latest release was published in 2022-01-15:
|
|
Is there a release planned somewhere soon? This happens to me daily, the only way to prevent this is to de-select the text tool before clicking somewhere, when editing text. Huge pain in the bum, if you add multiple texts to a screenshot and then flameshot aborts on the last click... |
|
@thraizz you can build from source or install from nightly builds: |
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
May 13, 2022
(cherry picked from commit 4affa92)
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
close()method was aborting the screenshot. I am not sure why only on thetexttool.I went for a safer approach which consist on hiding the tool and to avoid any leak I am setting its parent and flagging the widget to
deleteLater().