Right click to open panel and select tool

[deo002]

Closes #1917.

Created two seperate signals for left click and right click and handled them accordingly.

Current behaviour:

• Right click on drawing tools to select them and open side panel.
• If tool is already selected, then on right clicking it, it is not deselected and only side panel is opened.
• Once the side panel is opened, further clicking any tool won't close it.

[veracioux]

@mmahmoudian You have anything to add/change?

[mmahmoudian]

I checked the code quickly and then compiled against eb0d284 and the right-click does not open the side panel this is the hash of the compiled file: 4dd5ef3c6c3f69f041c8b9439ac0ea4be7c5d784

I can't put my finger on what is the issue though. @veracioux did it work for you?

I think the issue is on my end. wait...

[mmahmoudian]

It also seems that our AppImage upload script is broken: https://github.com/flameshot-org/flameshot/runs/3999071759?check_suite_focus=true

[veracioux]

@mmahmoudian Works fine on my end. My hash:

SHA1: 9ec8a4642853eebd589307e241b396ac0c5b1c22
MD5: b63521e1d22370b23ed5ec722049e4b7

It also seems that our AppImage upload script is broken: https://github.com/flameshot-org/flameshot/runs/3999071759?check_suite_focus=true

If you mean the fact that the "Artifacts" button is missing, it's a GitHub bug (started bugging me recently). You just have to remove the ?check_suite_focus=true text from the URL. I.e. https://github.com/flameshot-org/flameshot/runs/3999071759

[mmahmoudian]

Works fine on my end

It works. the issue was totally on my end.

But surprisingly enough for some reason my hash is different: SHA1: fb0d6be51d84da5b62656e1976be6c953121b690 I wonder what can be the issue/difference

You have anything to add/change?

What I think is a bit confusing is that when I right-click on different buttons (e.g highlight, line, arrow, square) I don't see any difference in the side panel, but in action it is changing. I wanted to suggest to add some title to the top of the side panel to say this is settings for this tool, but then I realized because this setting is not tool-specific, it would also become confusing if we put a title there as user might think the setting is tool-specific. If you have a quick suggestion for this, let's address it, if not, let's merge this one and see what the feedback would be. After all this is not a totally new feature and it is just another way to open settings.

If you mean the fact that the "Artifacts" button is missing

No, I meant that if you check the log for the AppImage under the "Upload appimage package for daily build" you can see that there are some error and ultimately the artifact is not uploaded, whereas the checksum has been successfully uploaded in the previous chunk of the log file!

it's a GitHub bug (started bugging me recently).

I don't think it is a bug, they have re-arrange the UI a bit. if you go to https://github.com/flameshot-org/flameshot/actions/runs/1381805133 and scroll to the bottom you will see the artifacts in a separate section. I think by moving it down there is a plan to gradually remove it (?)

[veracioux]

@mmahmoudian

But surprisingly enough for some reason my hash is different: SHA1: fb0d6be51d84da5b62656e1976be6c953121b690 I wonder what can be the issue/difference

Probably different build type/flags. Maybe the compiler version can affect this as well. Come to think of it, comparing hashes of a compiled executable does not strike me as reliable.

What I think is a bit confusing is that when I right-click on different buttons (e.g highlight, line, arrow, square) I don't see any difference in the side panel, but in action it is changing. I wanted to suggest to add some title to the top of the side panel to say this is settings for this tool, but then I realized because this setting is not tool-specific, it would also become confusing if we put a title there as user might think the setting is tool-specific.

I don't know what you mean by "in action it is changing". But I am fine with the current behavior, and I can't recall any recent changes in the workflow files.

No, I meant that if you check the log for the AppImage under the "Upload appimage package for daily build" you can see that there are some error and ultimately the artifact is not uploaded, whereas the checksum has been successfully uploaded in the previous chunk of the log file!

I see. Maybe it's just a temporary connection problem with the service. The previous commit didn't have this problem.

I don't think it is a bug, they have re-arrange the UI a bit. if you go to https://github.com/flameshot-org/flameshot/actions/runs/1381805133 and scroll to the bottom you will see the artifacts in a separate section.

Thanks, good to know.