-
Notifications
You must be signed in to change notification settings - Fork 370
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed a bug in determining default integer size.
Details: - Fixed a bug that would cause configurations to inadvertantly define their integers to be 32 bits when those environments actually call for 64-bit integers. While either BLIS_ARCH_64 or BLIS_ARCH_32 is defined in bli_system.h (based on whether preprocessor macros such as __x86_64 or __aarch64__ are defined by the environment), bli_system.h was being #included *after* bli_config_macro_defs.h, in which the BLIS_ARCH_64 macro was used to choose an integer type size in the event that BLIS_INT_TYPE_SIZE was not already defined by configure via bli_config.h. And due to the structure of the cpp code in that file, the 32-bit integer case was being chosen. Thanks to Francisco Igual and Devangi Parikh for their help in isolating this bug. - Moved the #include of hbwmalloc.h and related preprocessor code to bli_kernel_macro_defs.h to facilitate the reshuffling of the #include for bli_system.h in blis.h.
- Loading branch information
Showing
3 changed files
with
20 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters