Fix: error in safename for feature and attributes in Writers

flamapy/metamodels/fm_metamodel/transformations/clafer_writer.py

@@ -153,7 +153,7 @@ def parse_type_value(value: Any) -> str:
 
 
 def safename(name: str) -> str:
-    return f'"{name}"' if any(char in name for char in safecharacters()) else name
+    return f'"{name}"' if any(char not in safecharacters() for char in name) else name
 
 
 def safecharacters() -> str:

flamapy/metamodels/fm_metamodel/transformations/featureide_writer.py

@@ -140,7 +140,7 @@ def prettify(xml: str) -> bytes:
 
 
 def safename(name: str) -> str:
-    return f'"{name}"' if any(char in name for char in safecharacters()) else name
+    return f'"{name}"' if any(char not in safecharacters() for char in name) else name
 
 
 def safecharacters() -> str:

flamapy/metamodels/fm_metamodel/transformations/glencoe_writer.py

@@ -107,7 +107,7 @@ def _get_ctc_info(ast_node: Node) -> dict[str, Any]:
 
 
 def safename(name: str) -> str:
-    return f'"{name}"' if any(char in name for char in safecharacters()) else name
+    return f'"{name}"' if any(char not in safecharacters() for char in name) else name
 
 
 def safecharacters() -> str:

flamapy/metamodels/fm_metamodel/transformations/json_writer.py

@@ -127,7 +127,7 @@ def get_ctc_info(ast_node: Node) -> Dict[str, Any]:
 
 
 def safename(name: str) -> str:
-    return f'"{name}"' if any(char in name for char in safecharacters()) else name
+    return f'"{name}"' if any(char not in safecharacters() for char in name) else name
 
 
 def safecharacters() -> str:

flamapy/metamodels/fm_metamodel/transformations/splot_writer.py

@@ -85,7 +85,7 @@ def add_constraints(constraints: list[Constraint]) -> list[str]:
 
 
 def safename(name: str) -> str:
-    return f'"{name}"' if any(char in name for char in safecharacters()) else name
+    return f'"{name}"' if any(char not in safecharacters() for char in name) else name
 
 
 def safecharacters() -> str:

flamapy/metamodels/fm_metamodel/transformations/uvl_reader.py

@@ -95,8 +95,9 @@ def process_attributes(
                 logging.warning("This attributes are not yet supported in flama.")
             else:
                 # Handle unexpected case
+                attribute_name = attribute_context.getText().replace('"', '')
                 raise ValueError(
-                    f"Unknown attribute type for: {attribute_context.getText().replace('"', '')}"
+                    f"Unknown attribute type for: {attribute_name}"
                 )
 
             attributes_dict[key] = value

flamapy/metamodels/fm_metamodel/transformations/uvl_writer.py

@@ -136,7 +136,7 @@ def serialize_constraint(ctc: Constraint) -> str:
 
 
 def safename(name: str) -> str:
-    return f'"{name}"' if any(char in name for char in safecharacters()) else name
+    return f'"{name}"' if any(char not in safecharacters() for char in name) else name
 
 
 def safecharacters() -> str: