fix: issue solved in the configurations op

flamapy · Aug 22, 2024 · 9767f68 · 9767f68
1 parent 7216835
commit 9767f68
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/flamapy/metamodels/bdd_metamodel/operations/bdd_metrics.py b/flamapy/metamodels/bdd_metamodel/operations/bdd_metrics.py
@@ -40,11 +40,11 @@ def __init__(self) -> None:
     @property
     def model_type_extension(self) -> str:
         return self._model_type_extension
-    
+
     @model_type_extension.setter
     def model_type_extension(self, ext: str) -> None:
         self._model_type_extension = ext
-    
+
     def get_result(self) -> list[dict[str, Any]]:
         return self.result
 

diff --git a/flamapy/metamodels/bdd_metamodel/operations/bdd_product_distribution.py b/flamapy/metamodels/bdd_metamodel/operations/bdd_product_distribution.py
@@ -141,7 +141,7 @@ def descriptive_statistics(prod_dist: list[int]) -> dict[str, Any]: # noqa: MC00
     mode = None
 
     sum_squared_diff = 0
-    abs_deviation_total = 0
+    abs_deviation_total = 0.0
     abs_deviation_running_total = 0
     mad1: Optional[float] = None
     mad2: Optional[float] = None

diff --git a/flamapy/metamodels/bdd_metamodel/operations/bdd_satisfiable_configuration.py b/flamapy/metamodels/bdd_metamodel/operations/bdd_satisfiable_configuration.py
@@ -1,4 +1,4 @@
-from typing import Any, Optional, cast
+from typing import Optional, cast
 
 from flamapy.core.models import VariabilityModel
 from flamapy.metamodels.configuration_metamodel.models import Configuration
@@ -18,7 +18,7 @@ def set_configuration(self, configuration: Configuration) -> None:
 
     def execute(self, model: VariabilityModel) -> 'BDDSatisfiableConfiguration':
         bdd_model = cast(BDDModel, model)
-        self._result = is_satisfiable(bdd_model, self._configuration, self._is_full)
+        self._result = is_satisfiable(bdd_model, self._configuration)
         return self
 
     def get_result(self) -> bool:
@@ -29,7 +29,7 @@ def is_satisfiable(self) -> bool:
 
 
 def is_satisfiable(bdd_model: BDDModel,
-                   configuration: Optional[Configuration]) -> bool:
+                   configuration: Configuration) -> bool:
     config_number_op = BDDConfigurationsNumber()
     if not configuration.is_full:
         config_number_op.set_partial_configuration(configuration)

diff --git a/requirements.txt b/requirements.txt
@@ -1,4 +1,4 @@
 flamapy-fw~=2.0.0
 flamapy-fm~=2.0.0
-dd~=0.6.0
+dd~=0.5.7
 graphviz~=0.20