Add sentence labeler #3570
Merged
Add sentence labeler #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGPT-ai
force-pushed
the
add-sentence-labeler
branch
2 times, most recently
from
fdae4ef to
a711cb6
Compare
helpmefindaname
requested changes
Dec 6, 2024
MattGPT-ai
force-pushed
the
add-sentence-labeler
branch
from
c5a7277 to
bc7fa10
Compare
|
I addressed your change request, is there anything else that you need me to change or can this be merged? |
alanakbik
reviewed
Feb 3, 2025
alanakbik
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks a lot for adding this and sorry for taking so long to review! See the comments for suggested changes.
Generally, I think this is quite a useful helper function for all Flair dataset classes that have annotations labeled as character offsets.
Regarding the chunking/truncation, it would be nice in the future to have such functionality be attached to the Corpus class, similar to the filter_long_sentences method but with truncation or chunking rather than filtering. This way, it could be used for any corpus.
MattGPT-ai
force-pushed
the
add-sentence-labeler
branch
from
f726672 to
082e845
Compare
alanakbik
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplified version of the chunking utility provided in #3520