Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed srec parsing issues for files with additional data at the end #99

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Nov 11, 2022

There are frequent unpacking errors when trying to unpack srec files that were carved by binwalk and have additional data at the end. This PR should ensure that the correct file end is used when parsing those records.

I also changed the "bad" test files from syntax errors to "valid errors" (as far as the syntax is concerned): checksum mismatch and wrong length).

@jstucke jstucke added the bug Something isn't working label Nov 11, 2022
@jstucke jstucke requested a review from rhelmke November 11, 2022 14:55
@jstucke jstucke self-assigned this Nov 11, 2022
@rhelmke rhelmke merged commit c1eeeb8 into master Nov 17, 2022
@rhelmke rhelmke deleted the srec-parsing-bugfix branch November 17, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants