Sasquatch update #142
Merged
Sasquatch update #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorpvom
requested changes
Jul 23, 2024
fact_extractor/install/unpacker.py
Outdated
| for file_name, url, sha256 in EXTERNAL_DEB_DEPS: | ||
| try: | ||
| run(split(f'wget {url}/{file_name}'), check=True, env=os.environ) | ||
| assert _sha256_hash_file(Path(file_name)) == sha256 |
There was a problem hiding this comment.
Are you sure this will actually throw in production? I remeber reading something to that point. All I could find by short research was this from the official docs:
The current code generator emits no code for an assert statement when optimization is requested at compile time
So this might be irrelevant. We would be safe by throwing an exception manually though (InstallationError).
dorpvom
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
branch is based on #140 (should be merged first)