support dict merging in fieldmanager and add_fields_to method #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified and streamlined logic for merging fields and resolving overwrite/extend conflicts. - Improved support for merging dictionaries and extending lists in `add_fields_to`. - Added tests to validate new behaviors and handle edge cases more effectively.
- Replaced `extend_target_list` with `merge_with_target` across processors and utilities for clarity and better functionality. - Ensured proper handling of scenarios where merging and overwriting targets could conflict.
- Ensures all values in the `prefixed_label` dictionary are lists. - Adds a unit test to validate the behavior for labeler rules.
- moves test at the end of the list
- Simplifies conditional branches by reordering merge cases. - Streamlines how source values and targets are handled. - Ensures proper handling of dict merging and overwrite flags.
- Introduced a new test case to validate merging response data with an existing dictionary. - Ensures proper behavior when "merge_with_target" is enabled in the requester configuration.
dtrai2
changed the title
ekneg54
approved these changes
Jan 3, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
+ Coverage 94.32% 96.57% +2.25%
==========================================
Files 146 145 -1
Lines 9724 9340 -384
==========================================
- Hits 9172 9020 -152
+ Misses 552 320 -232 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldManagerto merge dictsextend_target_listtomerge_with_target(breaking change)