Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING file #664

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Add CONTRIBUTING file #664

merged 3 commits into from
Sep 23, 2024

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Sep 10, 2024

This adds contribution guidelines to this repository.
The file should support external developers on contributions.

Please have a look.

@ekneg54 ekneg54 self-assigned this Sep 10, 2024
ppcad
ppcad requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@ppcad ppcad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.
I have added some small remarks.

Furthermore, some sentences end with a period and some don't.
I think this should be consistent.

CHANGELOG.md Show resolved Hide resolved
CONTRIBUTING Outdated Show resolved Hide resolved
@ekneg54 ekneg54 force-pushed the dev-add-contributing-file branch from 71031f3 to 84bb6d9 Compare September 23, 2024 06:30
@ekneg54 ekneg54 requested a review from ppcad September 23, 2024 06:30
@ekneg54
Copy link
Collaborator Author

ekneg54 commented Sep 23, 2024

I fixed the missing periods. @ppcad please have a look again

ppcad
ppcad requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@ppcad ppcad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the punctuation.

My question about the file extension remains.

@ekneg54 ekneg54 requested a review from ppcad September 23, 2024 07:14
@ekneg54
Copy link
Collaborator Author

ekneg54 commented Sep 23, 2024

@ppcad I answered your question. Please have a look again.

@ekneg54 ekneg54 merged commit c6f4d77 into main Sep 23, 2024
13 checks passed
@ekneg54 ekneg54 deleted the dev-add-contributing-file branch September 23, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djkhl djkhl djkhl approved these changes

@ppcad ppcad ppcad approved these changes

@Malutthias Malutthias Malutthias approved these changes

Assignees

@ekneg54 ekneg54

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekneg54 @Malutthias @ppcad @djkhl