Fix grokker rules that have fields with common prefixes #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekneg54
requested changes
Apr 24, 2024
logprep/processor/grokker/rule.py
Outdated
Comment on lines
71
to
72
| split_field = dotted_field.split(".") | ||
| if len(split_field) > 1: |
There was a problem hiding this comment.
Suggested change
| split_field = dotted_field.split(".") | |
| if len(split_field) > 1: | |
| if "." in dotted_field: |
- if a dot is in dotted field, the length will be greater than 1
- much cheaper operation than two method calls
There was a problem hiding this comment.
Well we still need the dotted_field.split(".") in the next line. So what I could offer is something like following. But it doesn't really reduce the method calls except the change of len(...) > 1 to "." in dotted_field.
if "." in dotted_field:
replacement = "".join(f"[{element}]" for element in dotted_field.split("."))
ekneg54
approved these changes
Apr 24, 2024
…ady-existing-field
ekneg54
deleted the
564-grokker-wont-allow-for-extension-of-already-existing-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #564