Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exchange version string generation from versioneer to setuptools-scm #549

Merged
merged 21 commits into from
Mar 27, 2024

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Mar 22, 2024

TODO:

  • use setuptools_scm for version generation
  • fix tests that depend on get_version by reimplementing it
  • exclude unneeded files from package
  • fix version for containerbuilds

closes #533
closes #549

@ekneg54 ekneg54 linked an issue Mar 22, 2024 that may be closed by this pull request
@ekneg54 ekneg54 self-assigned this Mar 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (a326605) to head (6222f2a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   92.49%   94.38%   +1.89%     
==========================================
  Files         145      143       -2     
  Lines       10245     9885     -360     
==========================================
- Hits         9476     9330     -146     
+ Misses        769      555     -214     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekneg54 ekneg54 marked this pull request as ready for review March 22, 2024 14:34
@ekneg54 ekneg54 requested a review from ppcad March 22, 2024 14:35
Copy link
Collaborator

@ppcad ppcad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running the pex for this pull-request I get version 0.1.dev1+g3650834.
Is that the desired behavior?

@ekneg54
Copy link
Collaborator Author

ekneg54 commented Mar 25, 2024

It is not the desired behavior for sure :)
But pex build will be deleted in near future as I've heard ;)
Do you think it is worth it to fix this?

@ekneg54 ekneg54 requested a review from ppcad March 25, 2024 16:58
@ekneg54 ekneg54 force-pushed the 546-logprep-version-string-broken-for-releases-1004 branch from 063e059 to 204d8df Compare March 27, 2024 07:52
@ekneg54 ekneg54 merged commit 2186732 into main Mar 27, 2024
10 checks passed
@ekneg54 ekneg54 deleted the 546-logprep-version-string-broken-for-releases-1004 branch March 27, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logprep version string broken for releases 10.0.4 Wrong logprep version in feature branch container images
3 participants