-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exchange version string generation from versioneer to setuptools-scm #549
exchange version string generation from versioneer to setuptools-scm #549
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 92.49% 94.38% +1.89%
==========================================
Files 145 143 -2
Lines 10245 9885 -360
==========================================
- Hits 9476 9330 -146
+ Misses 769 555 -214 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running the pex for this pull-request I get version 0.1.dev1+g3650834.
Is that the desired behavior?
It is not the desired behavior for sure :) |
063e059
to
204d8df
Compare
TODO:
get_version
by reimplementing itcloses #533
closes #549