Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic oauth2 token retrieval #531

Merged
merged 100 commits into from
Mar 25, 2024

Conversation

dtrai2
Copy link
Collaborator

@dtrai2 dtrai2 commented Feb 23, 2024

Adds the possibility to automatically retrieve access tokens from one running keycloak instance.

ToDos:

  • implement feature
  • clean up implementation
  • add documentation
  • add tests

@dtrai2 dtrai2 added the enhancement New feature or request label Feb 23, 2024
@dtrai2 dtrai2 self-assigned this Feb 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 99.12281% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.54%. Comparing base (31188ed) to head (bb63c92).
Report is 2 commits behind head on main.

Files Patch % Lines
logprep/util/credentials.py 99.04% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   92.34%   92.54%   +0.20%     
==========================================
  Files         144      145       +1     
  Lines       10041    10233     +192     
==========================================
+ Hits         9272     9470     +198     
+ Misses        769      763       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtrai2 dtrai2 mentioned this pull request Mar 4, 2024
4 tasks
@dtrai2 dtrai2 changed the title add first draft for automatic retrival Automatic oauth2 token retrieval Mar 4, 2024
logprep/util/getter.py Outdated Show resolved Hide resolved
logprep/util/getter.py Outdated Show resolved Hide resolved
logprep/util/getter.py Outdated Show resolved Hide resolved
logprep/util/getter.py Outdated Show resolved Hide resolved
@ekneg54 ekneg54 force-pushed the dev-automatic-token-retrival-from-keycloak branch from f67a358 to 4b088a8 Compare March 15, 2024 08:29
@ekneg54 ekneg54 linked an issue Mar 15, 2024 that may be closed by this pull request
@ekneg54 ekneg54 marked this pull request as ready for review March 25, 2024 12:24
@ekneg54 ekneg54 force-pushed the dev-automatic-token-retrival-from-keycloak branch from 90826bd to 8469424 Compare March 25, 2024 14:41
@ekneg54 ekneg54 merged commit a326605 into main Mar 25, 2024
10 checks passed
@ekneg54 ekneg54 deleted the dev-automatic-token-retrival-from-keycloak branch March 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container builds for branches broken
4 participants