Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local datastore bootstrap #58

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

jonathansberry
Copy link
Member

@jonathansberry jonathansberry commented Jan 16, 2025

Description

This PR fixes the local datastore bootstrap. Previously this was coupled into the RDS bootstrapping process, creating problems as cloud environment databases had admin and ckan users sharing password. This was fixed here, but left a problem for thos CKAN instances with datapusher enabled. The local dev env db is bootstrapped in a different way to the cloud dbs. This PR ensures that the RDS bootstrapping doesn't take place in local, but that the datastore db and users are still created if datapushed is enabled.

I believe this should close issue: https://github.com/fjelltopp/fjelltopp-infrastructure/issues/333

Tested manually for WAC

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The GitHub ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested locally on ZaRR. If we get it merged I can do a staging deploy.

@jonathansberry jonathansberry merged commit fdf59ef into master Jan 16, 2025
@jonathansberry jonathansberry deleted the fix-datastore-bootstrap branch January 16, 2025 12:48
Copy link

🚀 [bumpr] Bumped! New version:v3.1.2 Changes:v3.1.1...v3.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants