Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification cron job #54

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Notification cron job #54

merged 1 commit into from
Dec 19, 2024

Conversation

jonathansberry
Copy link
Member

@jonathansberry jonathansberry commented Dec 19, 2024 •
edited
Loading

Description

Improvement to the notification cronjob. In DMS we are still using an ansible variable ckan_sysadmin_api_key. But we also now have ckan_admin_api_token. Api keys have been deprecated (I think someone has just set the secret to a token in AWS since it is working). But it would be better to clean this up and get rid of the duplicate ansible variable that is only used in DMS.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The GitHub ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@jonathansberry jonathansberry enabled auto-merge (squash) December 19, 2024 11:14
ChasNelson1990
ChasNelson1990 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great move

@jonathansberry jonathansberry merged commit 20964bf into master Dec 19, 2024
@jonathansberry jonathansberry deleted the notification-cron-job branch December 19, 2024 11:21
@github-actions GitHub Actions
Copy link

🚀 [bumpr] Bumped! New version:v3.0.5 Changes:v3.0.4...v3.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChasNelson1990 ChasNelson1990 ChasNelson1990 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathansberry @ChasNelson1990