-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First steps towards upgrading Kubernetes, Minikube and Python. #42
base: master
Are you sure you want to change the base?
First steps towards upgrading Kubernetes, Minikube and Python. #42
Conversation
This PR should remain a draft until all projects can work with the changes made.
Moreover, I've been getting an error trying to have the
So until error messages such as those are resolved, this PR cannot be merged. |
That datapusher image is very old (as we found out in AFRO) and likely shouldn't be used by any of our projects. AFRO uses one built from https://github.com/fjelltopp/datapusher |
@@ -2,11 +2,11 @@ | |||
aws_region: "eu-west-1" | |||
# Current EKS Kubernetes version | |||
# https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html | |||
k8s_version: "1.24" | |||
k8s_version: "1.30" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 1.31?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.30 is LTS I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's a distinction AWS make tbh, if we go 1.30 now, will have to do this again before July 28, 2025 to avoid fees. 1.31 would give an extra 6 months (although we should get in the habit of doing it frequently)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool - 1.31 it is!
And, yes, we probably need to get into the habit of doing this at least annually.
|
||
[requires] | ||
python_version = "3.8" | ||
python_version = "3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is already proposed here: #36
@@ -22,6 +22,7 @@ uamqp = "*" | |||
requests = {extras = ["security"], version = "<2.32"} | |||
psycopg2 = "*" | |||
resolvelib = "==0.8.1" | |||
urllib3 = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have urllib3 in my lock file without having specified it in the Pipfile. I guess there is no danger to this though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's in our lockfile already then we don't need to put it here, especially as a wildcard. Either it should be a specific version (ideally everything should be but let's start here) or not added.
Description
This PR upgrades Kubernetes, Minikube and Python to newer versions that have at least one year of support.
Dependency Changes
The Pipfile now adds
urllib3
as a dependency since it is required for a successful deployment.Documentation (TODO)
Once this has been successfully done, the documentation must be updated to reflect the change in the Python version.
See the CKAN project build & deployment page for the need to do this -- it specifically asks users to have Python 3.8 installed.
Checklist