-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRC-69 Fix resolvelib to a valid version #32
Conversation
That would be nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The reason Pipenv has not handled this is because we aren't installing ansible-galaxy through pipenv... well it's not in the lockfile anyway... does ansible pull this in somewhere else?
Galaxy comes with ansible. Is it possible (and more importantly, sensible) to move these to pip? |
Don't think we can... they aren't python packages per se, right... they are cascades of never ending ansible galaxy ymls, right? |
@mixmixmix leaving for you to rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚀 [bumpr] Bumped! New version:v1.3.1 Changes:v1.3.0...v1.3.1 |
Description
WRC (Romania) jenkins deployments have been failing with the following error:
The pipfile lock in fjelltopp ansible says that resolve lib is set at 1.0.1 - i.e. outside what ansible-galaxy requires.
Surely pipenv/pip's job is to resolve this properly?
Anyhows... doing a simple
pipenv install resolvelib==0.8.1
seems to fix this issue (see logs here).0.8.1
was the version of resolve lib we had previously in the pipfile.lock. I have therefore relocked the pipfile with this change.I've ensured I lock the pipfile with the same version of pipenv used on jenkins (
pip install pipenv=2021.11.23
) but are we using this version in Azure?Merging this and bumping fjelltopp-ansible in infrastructure will fix WRC deployments in Jenkins.
Dependency Changes
Changes the version of resolvelib and relocks pipfile.
Testing
I have deployed WHO romania with this new pipfile lock from jenkins (e.g. here) and it worked well. I have not tested other projects and Azure though.
Checklist
Put an
x
in the boxes that apply to this pull request (you can also fill these out after opening the pull request).You may not need to check all boxes.