Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRC-69 Fix resolvelib to a valid version #32

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

jonathansberry
Copy link
Member

@jonathansberry jonathansberry commented Sep 5, 2024

Description

WRC (Romania) jenkins deployments have been failing with the following error:

ERROR! ansible-galaxy requires resolvelib<0.9.0,>=0.5.3

The pipfile lock in fjelltopp ansible says that resolve lib is set at 1.0.1 - i.e. outside what ansible-galaxy requires.

Surely pipenv/pip's job is to resolve this properly?

Anyhows... doing a simple pipenv install resolvelib==0.8.1 seems to fix this issue (see logs here). 0.8.1 was the version of resolve lib we had previously in the pipfile.lock. I have therefore relocked the pipfile with this change.

I've ensured I lock the pipfile with the same version of pipenv used on jenkins (pip install pipenv=2021.11.23) but are we using this version in Azure?

Merging this and bumping fjelltopp-ansible in infrastructure will fix WRC deployments in Jenkins.

Dependency Changes

Changes the version of resolvelib and relocks pipfile.

Testing

I have deployed WHO romania with this new pipfile lock from jenkins (e.g. here) and it worked well. I have not tested other projects and Azure though.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@cooper667
Copy link
Collaborator

Surely pipenv/pip's job is to resolve this properly?

That would be nice!

ChasNelson1990
ChasNelson1990 previously approved these changes Sep 9, 2024
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The reason Pipenv has not handled this is because we aren't installing ansible-galaxy through pipenv... well it's not in the lockfile anyway... does ansible pull this in somewhere else?

@cooper667
Copy link
Collaborator

LGTM. The reason Pipenv has not handled this is because we aren't installing ansible-galaxy through pipenv... well it's not in the lockfile anyway... does ansible pull this in somewhere else?

Galaxy comes with ansible. Is it possible (and more importantly, sensible) to move these to pip?

@ChasNelson1990
Copy link
Member

Galaxy comes with ansible. Is it possible (and more importantly, sensible) to move these to pip?

Don't think we can... they aren't python packages per se, right... they are cascades of never ending ansible galaxy ymls, right?

@ChasNelson1990
Copy link
Member

@mixmixmix leaving for you to rebase

@ChasNelson1990 ChasNelson1990 self-requested a review September 18, 2024 11:46
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mixmixmix mixmixmix merged commit 57f27d2 into master Sep 24, 2024
@mixmixmix mixmixmix deleted the WRC-69-fix-resolvelib branch September 24, 2024 09:25
Copy link

🚀 [bumpr] Bumped! New version:v1.3.1 Changes:v1.3.0...v1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants