Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAC-108 fix: Refactor volumes #25

Merged
merged 10 commits into from
Aug 19, 2024
Merged

WAC-108 fix: Refactor volumes #25

merged 10 commits into from
Aug 19, 2024

Conversation

cooper667
Copy link
Collaborator

@cooper667 cooper667 commented Aug 18, 2024

Description

  • Use consistent naming everywhere (Azure blobs originally had a -blob suffix to differentiate from disks. This wasn't needed, as the underlying storage shouldn't matter to our containers).
  • Ran manual K8S commands on downstream deployments (Azure Staging) to copy files to new naming. I'd be grateful if someone could click around staging and check that anything supposed to be on a volume is
  • Remove Azure Specific ckan_volumes file. It's all one file now, with fairly simple templating so should be easy to reason about.

As far as I can tell ckan-resources isn't used? We have it in our deploys but it's empty. If we confirm this, we should remove in this PR.

Unsure if AWS support ReadWriteMany on the storage we use, so have left as RWO for now?

Testing (delete if not applicable)

Tested by deploy on Azure. I don't think it'll break AWS and local?

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@cooper667 cooper667 changed the title Refactor volumes fix: Refactor volumes Aug 18, 2024
@cooper667 cooper667 changed the title fix: Refactor volumes WAC-108 fix: Refactor volumes Aug 18, 2024
@cooper667 cooper667 marked this pull request as ready for review August 19, 2024 06:45
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can understand it all looks sensible and after clicking around staging seems too be fine

@cooper667 cooper667 marked this pull request as draft August 19, 2024 10:37
@cooper667 cooper667 marked this pull request as ready for review August 19, 2024 12:23
@cooper667
Copy link
Collaborator Author

The brokeness was due to the manual copying, not anything in this PR as far as i can tell

@cooper667 cooper667 merged commit 1273e7c into master Aug 19, 2024
@cooper667 cooper667 deleted the refactor_volumes branch August 19, 2024 12:50
Copy link

🚀 [bumpr] Bumped! New version:v1.1.0 Changes:v1.0.7...v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants