Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Who prod deploy #24

Merged
merged 95 commits into from
Aug 13, 2024
Merged

feat: Who prod deploy #24

merged 95 commits into from
Aug 13, 2024

Conversation

cooper667
Copy link
Collaborator

@cooper667 cooper667 commented Aug 13, 2024

Description

Minor fixes for Azure deployment.

  • Add gid to the mounts to prevent permissions errors when writing to volumes
  • Add role allowing AKS to access the container registry

Testing

It's tested in the sense it's currently deployed to prod

Documentation (delete if not applicable)

Minor confluence docs updates to mirror issues when deploying

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@cooper667 cooper667 self-assigned this Aug 13, 2024
@cooper667 cooper667 marked this pull request as ready for review August 13, 2024 05:33
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - I have a question about the file / dir mode on the mount - 0777 would obviously normally be a bit permissive, is there any cyber risk here?

@cooper667
Copy link
Collaborator Author

Looks fine to me - I have a question about the file / dir mode on the mount - 0777 would obviously normally be a bit permissive, is there any cyber risk here?

I actually got it working without this in the end so will remove

Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cooper667 cooper667 merged commit 72c90e2 into master Aug 13, 2024
@cooper667 cooper667 deleted the who_prod branch August 13, 2024 11:39
Copy link

🚀 [bumpr] Bumped! New version:v1.0.7 Changes:v1.0.6...v1.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants