Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to is_flask_request() #33

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jonathansberry
Copy link
Member

Description

is_flask_request() is deprecated as of CKAN 2.10. All requests are now flask. Here we remove the refernce from a piece of code that was copied from a CKAN core helper when running an older version of CKAN core. This should remove a never ending barage of warnings from production logs.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@jonathansberry jonathansberry enabled auto-merge (squash) December 17, 2024 14:54
@jonathansberry jonathansberry merged commit 927a4fd into master Dec 17, 2024
2 checks passed
@jonathansberry jonathansberry deleted the fix-remove-is-flask-request branch December 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant