-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
62 - Improve the system mobile view #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Toavina, Thanks for this! Great progress has been made. I've made a few small tweaks myself, but there are also a few larger outstanding issues I'm seeing...
- On the dataset read read pages I think the the primary content probably needs to come above the secondary content (the side column) it looks a bit funny otherwise. Do you agree? I also wonder whether we could hide the "duplication of the title" at the top of the secondary content, for small screens where everything is stacked in a single column.
- On the resource read page, the additional information section needs to come lower down underneath the resource title. In fact I think probably both primary and secondary content needs to come below module content. Ideally it would go module content (I.e. title/description/download link, previews), then primary content (i.e. additional information) then secondary content (i.e. resource selector).
- For screens 768 - 991px wide, there is a bug all pages with the side column. The primary content is taking up the full width (even though the side column is still visible) and therefore appearing below the secondary content in the side column. E.g. the dataset page here:
Committed fix from reviews. For third point, I had to hide the aside secondary for all pages except:
Review #1#2: Review #3: |
Thanks @A-Souhei for this great work! I've just added a few extra commits to fix a few other UI bugs I've noticed during development. I'll get it merged and deployed now. |
Description
Fixes for mobile DMS UI.
Closes https://github.com/fjelltopp/dms/issues/62.
Checklist
Put an
x
in the boxes that apply to this pull request (you can also fill these out after opening the pull request).You may not need to check all boxes.