Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CKAN 2.11 #30

Merged
merged 18 commits into from
Nov 19, 2024
Merged

Upgrade to CKAN 2.11 #30

merged 18 commits into from
Nov 19, 2024

Conversation

ntwalibas
Copy link
Contributor

Description

This PR does a few changes required for updating to CKAN 2.11:

  • Updates the UI as a few elements were broken after performing the upgrade.
  • Adds the get_site_statistics function to the helpers as it was removed from core CKAN helpers.
  • Upgrades the Axios library to a new version that fixes a known CSRF vulnerability.

This PR relates to

Dependency Changes

The Axios React library has been upgraded to account for a potential CSRF vulnerability.

Checklist

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@ntwalibas ntwalibas added the enhancement New feature or request label Nov 18, 2024
@ntwalibas ntwalibas requested review from cooper667, ChasNelson1990 and jonathansberry and removed request for cooper667 November 18, 2024 11:08
Copy link
Member

@jonathansberry jonathansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes to look at - hopefully all super easy to address.

ckanext/dms/assets/css/dms-main.css Outdated Show resolved Hide resolved
ckanext/dms/helpers.py Outdated Show resolved Hide resolved
ckanext/dms/helpers.py Outdated Show resolved Hide resolved
ckanext/dms/helpers.py Outdated Show resolved Hide resolved
ckanext/dms/helpers.py Outdated Show resolved Hide resolved
ckanext/dms/plugin.py Outdated Show resolved Hide resolved
…CSS rule, consolidate the way we import helpers in the plugin, and remove the import core CKAN modules in favor of using the toolkit.
@jonathansberry jonathansberry merged commit e3acd36 into master Nov 19, 2024
2 checks passed
@jonathansberry jonathansberry deleted the upgrade/ckan-2.11 branch November 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants