-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to CKAN 2.11 #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CKAN 2.11 while it was a core helper function before.
…s the version we were using was vulnerability to CSRF attacks: https://github.com/fjelltopp/ckanext-dms/security/dependabot/2.
ntwalibas
requested review from
cooper667,
ChasNelson1990 and
jonathansberry
and removed request for
cooper667
November 18, 2024 11:08
jonathansberry
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes to look at - hopefully all super easy to address.
…CSS rule, consolidate the way we import helpers in the plugin, and remove the import core CKAN modules in favor of using the toolkit.
jonathansberry
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a few changes required for updating to CKAN 2.11:
get_site_statistics
function to the helpers as it was removed from core CKAN helpers.This PR relates to
Dependency Changes
The Axios React library has been upgraded to account for a potential CSRF vulnerability.
Checklist