Skip to content

Commit

Permalink
test: Add basic balance coverage to wallet_assumeutxo.py
Browse files Browse the repository at this point in the history
  • Loading branch information
fjahr committed Sep 22, 2024
1 parent 037b101 commit f20fe33
Showing 1 changed file with 20 additions and 1 deletion.
21 changes: 20 additions & 1 deletion test/functional/wallet_assumeutxo.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
- TODO: test loading a wallet (backup) on a pruned node
"""
from test_framework.address import address_to_scriptpubkey
from test_framework.test_framework import BitcoinTestFramework
from test_framework.messages import COIN
from test_framework.util import (
assert_equal,
assert_raises_rpc_error,
Expand Down Expand Up @@ -65,10 +67,12 @@ def run_test(self):
# Create a wallet that we will create a backup for later (at snapshot height)
n0.createwallet('w')
w = n0.get_wallet_rpc("w")
w_address = w.getnewaddress()

# Create another wallet and backup now (before snapshot height)
n0.createwallet('w2')
w2 = n0.get_wallet_rpc("w2")
w2_address = w2.getnewaddress()
w2.backupwallet("backup_w2.dat")

# Generate a series of blocks that `n0` will have in the snapshot,
Expand Down Expand Up @@ -111,7 +115,13 @@ def run_test(self):

# Mine more blocks on top of the snapshot that n1 hasn't yet seen. This
# will allow us to test n1's sync-to-tip on top of a snapshot.
self.generate(n0, nblocks=100, sync_fun=self.no_op)
w_skp = address_to_scriptpubkey(w_address)
w2_skp = address_to_scriptpubkey(w2_address)
for i in range(100):
if i % 3 == 0:
self.mini_wallet.send_to(from_node=n0, scriptPubKey=w_skp, amount=1 * COIN)
self.mini_wallet.send_to(from_node=n0, scriptPubKey=w2_skp, amount=10 * COIN)
self.generate(n0, nblocks=1, sync_fun=self.no_op)

assert_equal(n0.getblockcount(), FINAL_HEIGHT)
assert_equal(n1.getblockcount(), START_HEIGHT)
Expand All @@ -136,6 +146,8 @@ def run_test(self):

self.log.info("Backup from the snapshot height can be loaded during background sync")
n1.restorewallet("w", "backup_w.dat")
# Balance of w wallet is still still 0 because n1 has not synced yet
assert_equal(n1.getbalance(), 0)

self.log.info("Backup from before the snapshot height can't be loaded during background sync")
assert_raises_rpc_error(-4, "Wallet loading failed. Error loading wallet. Wallet requires blocks to be downloaded, and software does not currently support loading wallets while blocks are being downloaded out of order when using assumeutxo snapshots. Wallet should be able to load successfully after node sync reaches height 299", n1.restorewallet, "w2", "backup_w2.dat")
Expand Down Expand Up @@ -172,6 +184,13 @@ def run_test(self):

self.log.info("Ensuring wallet can be restored from a backup that was created before the snapshot height")
n1.restorewallet("w2", "backup_w2.dat")
# Check balance of w2 wallet
assert_equal(n1.getbalance(), 340)

# Check balance of w wallet after node is synced
n1.loadwallet("w")
w = n1.get_wallet_rpc("w")
assert_equal(w.getbalance(), 34)


if __name__ == '__main__':
Expand Down

0 comments on commit f20fe33

Please sign in to comment.