-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create schedule spine incorporating timezones and daylight time #64
Create schedule spine incorporating timezones and daylight time #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments inline
flagging that i didn't add changelog stuff since that appears to the be in the release branch already? or i will add stuff after this PR is merged there... |
reminder to change packages.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just be sure to add the CHANGELOG
Are you a current Fivetran customer?
fivetran made PR
What change(s) does this PR introduce?
Does this PR introduce a breaking change?
Is this PR in response to a previously created Issue
How did you test the PR changes?
testing locally
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🤌
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.