Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create schedule spine incorporating timezones and daylight time #64

Merged
merged 14 commits into from
Feb 16, 2022

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Jan 21, 2022

Are you a current Fivetran customer?

fivetran made PR

What change(s) does this PR introduce?

  • adjusts circleci testing to be a bit more thorough
  • creates schedule spine model that incorporates timezones and daylight time stuff. down the line, when calculcating ticket metrics, we will determine which schedule to use based on the schedule_id it is associated with and what schedule (ie PT vs PST) is active when the ticket is active (wondering how to define this though, like do we pin the ticket on its creation date? what if a ticket is created a day before Daylight Savings starts or ends?)
  • incorporates the schedule spine into the business hours models
  • regenerate docs

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)

Is this PR in response to a previously created Issue

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)
    testing locally

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🤌

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments inline

@fivetran-jamie
Copy link
Contributor Author

flagging that i didn't add changelog stuff since that appears to the be in the release branch already? or i will add stuff after this PR is merged there...

@fivetran-jamie
Copy link
Contributor Author

reminder to change packages.yml

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just be sure to add the CHANGELOG

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 5783be5 into release/v0.8.0-official Feb 16, 2022
@fivetran-jamie fivetran-jamie deleted the timezone-tables branch August 29, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants