Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Divide by 0" error in stripe__line_item_enhanced #89

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Sep 23, 2024

PR Overview

This PR will address the following Issue/Feature:
#86

This PR will result in the following new package version:

This specific change would be 0.14.1, but batched with the other existing Stripe PRs, the release will probably be a breaking change

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

  • Addressed a potential Divide by 0 error in calculating unit_amount in the stripe__line_item_enhanced model. Now, if the denominator invoice_line_item.quantity is 0, unit_amount will also be 0.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Adjusted consistency_line_item_enhanced_count test to also look at differences in unit_amount (though this should be covered by consistency_line_item_enhanced as well) and all validation tests are passing
image

If you had to summarize this PR in an emoji, which would it be?

0️⃣

@fivetran-jamie fivetran-jamie self-assigned this Sep 23, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie thanks for working through this update. I just have a few small change requests before this will be good for approval.

Also, is the plan for this to be merged into main and cut as it's own patch update. Or, is the plan to batch this into a release branch along with the other in flight Stripe updates this sprint?

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie this looks good to go! My last request would be to add this same change to this PR. Just to ensure buildkite passes with the standardized model enabled.

Also, please make sure you regen the docs once you enable that variable in the integration_tests/dbt_project.yml. Otherwise, we will overwrite the hosted docs and it will remove the model from the docs. Thanks!

@fivetran-jamie
Copy link
Contributor Author

fivetran-jamie commented Sep 24, 2024

Great! So that change is actually already included in this branch (and the docs are regenerated). It's not showing up in the PR since main also has that

Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-jamie fivetran-jamie merged commit e2677a5 into main Sep 25, 2024
8 checks passed
@fivetran-jamie fivetran-jamie deleted the fix/divide-by-zero branch September 25, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants