Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.13.0 #78

Merged
merged 12 commits into from
May 27, 2024
Merged

Release/v0.13.0 #78

merged 12 commits into from
May 27, 2024

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented May 21, 2024

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

  • Breaking since the folder stripe_reports was renamed to stripe_financial_reports and could break if users relied on the old name.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🚨 Breaking Changes 🚨

  • Renamed folder stripe_reports to stripe_financial_reports to be more descriptive of the contents.
    • ⚠️ If you are using folder names to scope out configs, runs, etc., you will need to update the folder name.

Bug fixes

  • Updated model int_stripe__date_spine to accommodate cases when model stripe__balance_transactions has no records.
    • Previously, the date spine relied on stripe__balance_transactions to set date bounds, which caused errors if empty. Now, the model defaults to a one-month range in such cases.

Under the hood

  • Updated structure of model int_stripe__date_spine for improved performance and maintainability.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
    • Will regen after approval.
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • Validation tests pass.

If you had to summarize this PR in an emoji, which would it be?

🍓

@fivetran-catfritz fivetran-catfritz self-assigned this May 21, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz thanks for working on this update! I just have a few comments and suggestions before approving. Let me know if you have any questions regarding my comments. Thanks!

integration_tests/dbt_project.yml Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz thanks for answering my questions! Given the conversations from the comments, this looks good to go!

Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fivetran-catfritz fivetran-catfritz merged commit 2f792bb into main May 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants